9b2abf0952
chore(helm): add unit tests for helm chart ( #6557 )
...
This PR adds a minimum set of Helm tests for the Helm chart.
It's heavily based on the approach in [1], but uses a golden-files-based approach instead.
It also runs helm template directly instead of importing the entire Kubernetes API.
Golden files can be updated by running go test ./helm/tests -update or by running make update-golden-files.
[1] https://github.com/coder/enterprise-helm
Fixes #6552
2023-03-13 13:48:44 +00:00
179d9e0d24
fix(coderd): Detect agent disconnect via inactivity ( #6528 )
...
Fixes #5901
2023-03-13 11:54:53 +02:00
7fa6483d84
fix: allow the `BINARY_DIR` to be configured in the agent script ( #6567 )
2023-03-11 19:39:40 +00:00
37c859ec4c
chore: Ensure all audit types in ResourceTable match APGL ( #6563 )
...
* chore: Ensure all audit types in ResourceTable match APGL
* Implement more checks to ensure all tracked fields are present
* Add unit test to ensure all types are represented in audit table
* Trade compile time safety for syntax
2023-03-10 13:59:42 -06:00
a65a16122d
chore: early merge clibase foundations ( #6542 )
2023-03-10 13:41:32 -06:00
144f374f60
refactor(dbauthz): add authz for system-level functions ( #6513 )
...
- Introduces rbac.ResourceSystem
- Grants system.* to system and provisionerd rbac subjects
- Updates dbauthz system queries where applicable
- coderd: Avoid index out of bounds in api.workspaceBuilds
- dbauthz: move GetUsersByIDs out of system, modify RBAC check to ResourceUser
- workspaceapps: Add test case for when owner of app is not found
2023-03-10 18:09:28 +00:00
1db2b12b8e
chore: add a test to ensure audit code works with AGPL ( #6561 )
...
Fixes the regression seen in v0.19.1.
2023-03-10 17:04:40 +00:00
7eb2c2ff6d
Revert "chore: Implement joins with golang templates ( #6429 )" ( #6560 )
...
This reverts commit 8b125d6c5d
2023-03-10 10:39:02 -06:00
a8433b18e4
fix: Prevent infinite redirects on oidc errors ( #6550 )
...
* fix: Prevent infinite redirects on bad oidc scopes
* Show oidc errors
2023-03-10 10:12:29 -06:00
4a07fcd9d2
fix: ensure local derp uses the hostname ( #6559 )
...
This broke deployments that use a custom port with an access
URL. We should write a test for this!
2023-03-10 09:58:31 -06:00
8b125d6c5d
chore: Implement joins with golang templates ( #6429 )
...
* feat: Implement view for workspace builds to include rbac info
* Removes the need to fetch the workspace to run an rbac check.
* chore: Use workspace build as RBAC object
* chore: Use golang templates instead of sqlc files
2023-03-10 09:44:38 -06:00
a666539bfa
helm: add value for labels ( #6544 )
2023-03-10 07:39:55 -05:00
90901ca129
fix: panic on deleted template ( #6553 )
2023-03-10 12:26:11 +01:00
6023264a81
fix: typo in error message ( #6551 )
...
* fix: typo in error message
* fix
2023-03-10 09:20:22 +00:00
7f25d31745
feat: Allow changing the 'group' oidc claim field ( #6546 )
...
* feat: Allow changing the 'group' oidc claim field
* Enable empty groups support
* fix: Delete was wiping all groups, not just the single user's groups
* Update docs
* fix: Dbfake delete group member fixed
2023-03-09 23:31:38 -06:00
11a930e779
!fix: Disallow access urls without valid scheme ( #6548 )
...
Existing deployments will need to prepend a scheme if they have not already.
2023-03-09 21:37:19 -06:00
65878b04ce
fix: remove "something went wrong" text for watching a workspace ( #6541 )
...
This text wasn't useful to a customer anyways, because we don't get
an error from EventSource. This can happen if you close your laptop
and open it again, so it's better if we don't display it.
2023-03-09 20:54:28 +00:00
50432b89be
fix: pass git auth config read from environment through server ( #6540 )
2023-03-09 20:27:54 +00:00
1b3b0ea962
fix: adjust workspace filter query when the path changes ( #6539 )
...
Previously, when a status would change the filter wouldn't update.
This makes it update if a new value is passed in.
2023-03-09 14:23:23 -06:00
9a7998301b
fix: remove deployment bar info icon and adjust language ( #6537 )
...
Re @bpmct's feedback
2023-03-09 20:08:50 +00:00
4c2977050d
fix: treat empty env as defaults ( #6538 )
2023-03-09 19:58:58 +00:00
62a64d5a34
fix: remove deprecation warnings when option unset ( #6532 )
...
Resolves #6531
2023-03-09 19:22:21 +00:00
761ed7bf63
fix: rm pull request template ( #6533 )
...
It doesn't seem like this was helping anything.
2023-03-10 03:53:48 +10:00
2abae42cec
feat: Ignore agent pprof port in listening ports ( #6515 )
...
* feat: Ignore agent pprof port in listening ports
2023-03-09 10:53:00 -06:00
3de29307b5
chore: Remove some of the external enum comments in typescript ( #6530 )
...
* chore: Remove some of the external enum comments in typescript
handle clibase types manually
2023-03-09 10:46:23 -06:00
c2787e3a8e
docs: describe rich parameters ( #6527 )
...
* WIP
* WIP
* docs: describe rich parameters
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Update docs/templates/parameters.md
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
* Strip migration
* Fix
---------
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
2023-03-09 17:19:48 +01:00
70b093ff2a
fix: filter session count sums by `created_at` ( #6529 )
...
Fixes the session totals being waaaaay too high!
2023-03-09 17:08:41 +02:00
1cc10f2ffb
fix: only sum connection latencies when they are set ( #6524 )
...
This was producing a median that didn't make sense.
2023-03-09 03:53:09 +00:00
1199a9330a
chore: add fly.io install source ( #6509 )
2023-03-09 03:16:55 +00:00
a78786119d
chore: resolve race when running load tests with logs ( #6523 )
...
See https://github.com/coder/coder/actions/runs/4370166746/jobs/7644793277
2023-03-08 21:12:20 -06:00
5304b4e483
feat: add connection statistics for workspace agents ( #6469 )
...
* fix: don't make session counts cumulative
This made for some weird tracking... we want the point-in-time
number of counts!
* Add databasefake query for getting agent stats
* Add deployment stats endpoint
* The query... works?!?
* Fix aggregation query
* Select from multiple tables instead
* Fix continuous stats
* Increase period of stat refreshes
* Add workspace counts to deployment stats
* fmt
* Add a slight bit of responsiveness
* Fix template version editor overflow
* Add refresh button
* Fix font family on button
* Fix latest stat being reported
* Revert agent conn stats
* Fix linting error
* Fix tests
* Fix gen
* Fix migrations
* Block on sending stat updates
* Add test fixtures
* Fix response structure
* make gen
2023-03-08 21:05:45 -06:00
9d40d2ffdc
fix: remove create first user from the cli message ( #6493 )
...
This adjusts our setup to just show the Web UI, since you
can now create everything from there!
2023-03-09 02:54:46 +00:00
db2bdd1cab
fix: pass sdk header transport to websocket connections ( #6521 )
...
Fixes #6520 .
2023-03-09 02:29:02 +00:00
d67552f852
fix: add more cached certificates to azure instance identity ( #6519 )
...
This was failing for GovCloud. Now it falls back to fetch, and a test
has been added to notify when certificates are becoming outdated.
2023-03-08 19:32:10 -06:00
54bbed8c3c
chore: Fix default password and add more docs about scripts/develop.sh ( #6514 )
2023-03-08 21:50:55 +00:00
7df1e3bdd6
fix: centralize deployment config blocks to resolve race ( #6512 )
...
See https://github.com/coder/coder/actions/runs/4365865438/jobs/7635236079
2023-03-08 16:55:52 +00:00
95626d2076
fix: use correct LOG env names ( #6511 )
2023-03-08 16:27:32 +00:00
3b87316ad7
feat: propagate job error codes ( #6507 )
...
* feat: propagate job error_code
* fix
* Fix
* Fix
* Fix
* add errors to typesGenerated
* Address PR comments
* Fix
2023-03-08 16:32:00 +01:00
524b14adbc
fix: fetch provisioner logs after end of logs message ( #6495 )
...
I think this should _actually_ fix it. See
https://github.com/coder/coder/actions/runs/4358242625/jobs/7618562167
The problem was that this loop is ran async so even though
messages are sent in order, we were processing too slowly and
the end of logs was published first.
2023-03-09 01:13:08 +10:00
26a725f86d
fix: provisionerd: add more context to logs emitted, fix log level ( #6508 )
...
- Previously, we were logging all provision response logs at level INFO, regardless of the log level of the log streamed from the provisioner. We now log these at the original level (defaulting to INFO).
- Now logging "provision failed" message at level ERROR WARN and including the error field in the message.
2023-03-08 15:12:52 +00:00
89008125c0
refactor(site): Highlight immutable parameters and do a few tweaks ( #6490 )
2023-03-08 10:52:42 -03:00
fe10ba1157
fix: add audit information for WorkspaceBuild.MaxDeadilne ( #6504 )
...
* fix: add audit information for WorkspaceBuild.MaxDeadilne
* make gen
2023-03-08 12:41:57 +00:00
3b73321a6c
feat: refactor deployment config ( #6347 )
2023-03-07 15:10:01 -06:00
bb0a996fc2
chore: fix buffered provisioner job logs close flake ( #6492 )
...
See https://github.com/coder/coder/actions/runs/4357599919/jobs/7617111287
2023-03-07 20:08:13 +00:00
1bdd2abed7
feat: use JWT ticket to avoid DB queries on apps ( #6148 )
...
Issue a JWT ticket on the first request with a short expiry that
contains details about which workspace/agent/app combo the ticket is
valid for.
2023-03-07 19:38:11 +00:00
f8494d2bac
Update binary.md ( #6415 )
...
Fixed broken Link to release archive
2023-03-07 12:30:50 -06:00
f287889cd7
chore: move client pubsub for HA coordinator after register ( #6487 )
...
Similar fix that happened for the agent. See:
https://github.com/coder/coder/actions/runs/4356099388/jobs/7613634277
2023-03-07 16:46:54 +00:00
4c204fc348
chore: ensure auto-approve-docs has a deep enough depth ( #6484 )
...
* chore: ensure auto-approve-docs has a deep enough depth
This was failing on numerous PRs.
* Remove check because it isn't working
2023-03-07 10:05:00 -06:00
23bebb40e2
fix: bump migration to resolve duplicate id ( #6486 )
...
This happened because two PRs with different migrations
merged at the same time!
2023-03-07 10:04:06 -06:00
2d4706ac33
feat: mark coder_parameter as "required" ( #6433 )
...
* Add required column
* Pass through providerd
* Pass the required property down
* Optional
* Fix
* Fix
* Fix
* fix
* CLI create: support for optional fields
* Use HTML API to mark fields required
* Fix
* Improve validation
* more fixes
* make fmt
* Fix
* WIP
* Fix: test
* CLI update tets
* OptionalParameterAdded
* Fix: migration
2023-03-07 16:38:31 +01:00
Cian Johnston
Mathias Fredriksson
Kyle Carberry
Steven Masley
Ammar Bandukwala
Eric Paulsen
Marcin Tojek
Ben Potter
Bruno Quaresma
Dean Sheather
Hannes Rehburg