selfhosted
/
coder
mirror of https://github.com/coder/coder.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor(site): Remove optimistic workspace action (#7385)

This commit is contained in:
Bruno Quaresma 2023-05-02 18:38:53 -03:00 committed by GitHub
parent dd67283323
commit e6931d6920
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
site/src/xServices/workspace/workspaceXService.ts
View File

@ -385,7 +385,7 @@ export const workspaceMachine = createMachine(
}, },
}, },
requestingStart: { requestingStart: {
entry: ["clearBuildError", "updateStatusToPending"], entry: ["clearBuildError"],
invoke: { invoke: {
src: "startWorkspace", src: "startWorkspace",
id: "startWorkspace", id: "startWorkspace",
@ -404,7 +404,7 @@ export const workspaceMachine = createMachine(
}, },
}, },
requestingStop: { requestingStop: {
entry: ["clearBuildError", "updateStatusToPending"], entry: ["clearBuildError"],
invoke: { invoke: {
src: "stopWorkspace", src: "stopWorkspace",
id: "stopWorkspace", id: "stopWorkspace",
@ -423,7 +423,7 @@ export const workspaceMachine = createMachine(
}, },
}, },
requestingDelete: { requestingDelete: {
entry: ["clearBuildError", "updateStatusToPending"], entry: ["clearBuildError"],
invoke: { invoke: {
src: "deleteWorkspace", src: "deleteWorkspace",
id: "deleteWorkspace", id: "deleteWorkspace",
@ -442,11 +442,7 @@ export const workspaceMachine = createMachine(
}, },
}, },
requestingCancel: { requestingCancel: {
entry: [ entry: ["clearCancellationMessage", "clearCancellationError"],
"clearCancellationMessage",
"clearCancellationError",
"updateStatusToPending",
],
invoke: { invoke: {
src: "cancelWorkspace", src: "cancelWorkspace",
id: "cancelWorkspace", id: "cancelWorkspace",
@ -642,24 +638,7 @@ export const workspaceMachine = createMachine(
) )
displayError(message) displayError(message)
}, },
// Optimistically update. So when the user clicks on stop, we can show
// the "pending" state right away without having to wait 0.5s ~ 2s to
// display the visual feedback to the user.
updateStatusToPending: assign({
workspace: ({ workspace }) => {
if (!workspace) {
throw new Error("Workspace not defined")
}
return {
...workspace,
latest_build: {
...workspace.latest_build,
status: "pending" as TypesGen.WorkspaceStatus,
},
}
},
}),
assignMissedParameters: assign({ assignMissedParameters: assign({
missedParameters: (_, { data }) => { missedParameters: (_, { data }) => {
if (!(data instanceof API.MissingBuildParameters)) { if (!(data instanceof API.MissingBuildParameters)) {