mirror of https://github.com/coder/coder.git
fix: fix data race in TestLabelsAggregation tests (#12578)
This commit is contained in:
parent
7a7105ad66
commit
da54c8a51f
|
@ -204,14 +204,17 @@ func verifyCollectedMetrics(t *testing.T, expected []*agentproto.Stats_Metric, a
|
||||||
require.Failf(t, "unsupported type: %s", string(e.Type))
|
require.Failf(t, "unsupported type: %s", string(e.Type))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
expectedLabels := make([]*agentproto.Stats_Metric_Label, len(e.Labels))
|
||||||
|
copy(expectedLabels, e.Labels)
|
||||||
|
|
||||||
dtoLabels := asMetricAgentLabels(d.GetLabel())
|
dtoLabels := asMetricAgentLabels(d.GetLabel())
|
||||||
// dto labels are sorted in alphabetical order.
|
// dto labels are sorted in alphabetical order.
|
||||||
sortFn := func(i, j int) bool {
|
sortFn := func(i, j int) bool {
|
||||||
return e.Labels[i].Name < e.Labels[j].Name
|
return expectedLabels[i].Name < expectedLabels[j].Name
|
||||||
}
|
}
|
||||||
sort.Slice(e.Labels, sortFn)
|
sort.Slice(expectedLabels, sortFn)
|
||||||
sort.Slice(dtoLabels, sortFn)
|
sort.Slice(dtoLabels, sortFn)
|
||||||
require.Equal(t, e.Labels, dtoLabels, d.String())
|
require.Equal(t, expectedLabels, dtoLabels, d.String())
|
||||||
}
|
}
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue