selfhosted
/
coder
mirror of https://github.com/coder/coder.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: fix data race in TestLabelsAggregation tests (#12578)

This commit is contained in:
Danny Kopping 2024-03-13 13:47:22 +02:00 committed by GitHub
parent 7a7105ad66
commit da54c8a51f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
coderd/prometheusmetrics/aggregator_test.go
View File

@ -204,14 +204,17 @@ func verifyCollectedMetrics(t *testing.T, expected []*agentproto.Stats_Metric, a
require.Failf(t, "unsupported type: %s", string(e.Type))
}
expectedLabels := make([]*agentproto.Stats_Metric_Label, len(e.Labels))
copy(expectedLabels, e.Labels)
dtoLabels := asMetricAgentLabels(d.GetLabel())
// dto labels are sorted in alphabetical order.
sortFn := func(i, j int) bool {
return e.Labels[i].Name < e.Labels[j].Name
return expectedLabels[i].Name < expectedLabels[j].Name
}
sort.Slice(e.Labels, sortFn)
sort.Slice(expectedLabels, sortFn)
sort.Slice(dtoLabels, sortFn)
require.Equal(t, e.Labels, dtoLabels, d.String())
require.Equal(t, expectedLabels, dtoLabels, d.String())
}
return true
}