mirror of https://github.com/coder/coder.git
fix(coderd/agentapi): always write agent stats when provided (#12699)
This commit is contained in:
parent
bd6ad88077
commit
9c84fb7fb1
|
@ -47,11 +47,11 @@ func (a *StatsAPI) now() time.Time {
|
|||
}
|
||||
|
||||
func (a *StatsAPI) UpdateStats(ctx context.Context, req *agentproto.UpdateStatsRequest) (*agentproto.UpdateStatsResponse, error) {
|
||||
// An empty stat means it's just looking for the report interval.
|
||||
res := &agentproto.UpdateStatsResponse{
|
||||
ReportInterval: durationpb.New(a.AgentStatsRefreshInterval),
|
||||
}
|
||||
if req.Stats == nil || len(req.Stats.ConnectionsByProto) == 0 {
|
||||
// An empty stat means it's just looking for the report interval.
|
||||
if req.Stats == nil {
|
||||
return res, nil
|
||||
}
|
||||
|
||||
|
|
|
@ -222,9 +222,7 @@ func TestUpdateStates(t *testing.T) {
|
|||
|
||||
req = &agentproto.UpdateStatsRequest{
|
||||
Stats: &agentproto.Stats{
|
||||
ConnectionsByProto: map[string]int64{
|
||||
"tcp": 1,
|
||||
},
|
||||
ConnectionsByProto: map[string]int64{},
|
||||
ConnectionCount: 0,
|
||||
ConnectionMedianLatencyMs: 23,
|
||||
},
|
||||
|
@ -262,16 +260,14 @@ func TestUpdateStates(t *testing.T) {
|
|||
require.NoError(t, err)
|
||||
})
|
||||
|
||||
t.Run("NoConnectionsByProto", func(t *testing.T) {
|
||||
t.Run("NoStats", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
var (
|
||||
dbM = dbmock.NewMockStore(gomock.NewController(t))
|
||||
ps = pubsub.NewInMemory()
|
||||
req = &agentproto.UpdateStatsRequest{
|
||||
Stats: &agentproto.Stats{
|
||||
ConnectionsByProto: map[string]int64{}, // len() == 0
|
||||
},
|
||||
Stats: nil,
|
||||
}
|
||||
)
|
||||
api := agentapi.StatsAPI{
|
||||
|
|
Loading…
Reference in New Issue