mirror of https://github.com/coder/coder.git
fix(coderd/database): reduce db load via dbpurge advisory locking (#13021)
This commit is contained in:
parent
8a1216254e
commit
3adcccb618
|
@ -2,11 +2,10 @@ package dbpurge
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"errors"
|
|
||||||
"io"
|
"io"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"golang.org/x/sync/errgroup"
|
"golang.org/x/xerrors"
|
||||||
|
|
||||||
"cdr.dev/slog"
|
"cdr.dev/slog"
|
||||||
|
|
||||||
|
@ -35,22 +34,37 @@ func New(ctx context.Context, logger slog.Logger, db database.Store) io.Closer {
|
||||||
doTick := func() {
|
doTick := func() {
|
||||||
defer ticker.Reset(delay)
|
defer ticker.Reset(delay)
|
||||||
|
|
||||||
var eg errgroup.Group
|
start := time.Now()
|
||||||
eg.Go(func() error {
|
// Start a transaction to grab advisory lock, we don't want to run
|
||||||
return db.DeleteOldWorkspaceAgentLogs(ctx)
|
// multiple purges at the same time (multiple replicas).
|
||||||
})
|
if err := db.InTx(func(tx database.Store) error {
|
||||||
eg.Go(func() error {
|
// Acquire a lock to ensure that only one instance of the
|
||||||
return db.DeleteOldWorkspaceAgentStats(ctx)
|
// purge is running at a time.
|
||||||
})
|
ok, err := tx.TryAcquireLock(ctx, database.LockIDDBPurge)
|
||||||
eg.Go(func() error {
|
if err != nil {
|
||||||
return db.DeleteOldProvisionerDaemons(ctx)
|
return err
|
||||||
})
|
|
||||||
err := eg.Wait()
|
|
||||||
if err != nil {
|
|
||||||
if errors.Is(err, context.Canceled) {
|
|
||||||
return
|
|
||||||
}
|
}
|
||||||
|
if !ok {
|
||||||
|
logger.Debug(ctx, "unable to acquire lock for purging old database entries, skipping")
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := tx.DeleteOldWorkspaceAgentLogs(ctx); err != nil {
|
||||||
|
return xerrors.Errorf("failed to delete old workspace agent logs: %w", err)
|
||||||
|
}
|
||||||
|
if err := tx.DeleteOldWorkspaceAgentStats(ctx); err != nil {
|
||||||
|
return xerrors.Errorf("failed to delete old workspace agent stats: %w", err)
|
||||||
|
}
|
||||||
|
if err := tx.DeleteOldProvisionerDaemons(ctx); err != nil {
|
||||||
|
return xerrors.Errorf("failed to delete old provisioner daemons: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
logger.Info(ctx, "purged old database entries", slog.F("duration", time.Since(start)))
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}, nil); err != nil {
|
||||||
logger.Error(ctx, "failed to purge old database entries", slog.Error(err))
|
logger.Error(ctx, "failed to purge old database entries", slog.Error(err))
|
||||||
|
return
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -9,6 +9,7 @@ const (
|
||||||
LockIDDeploymentSetup = iota + 1
|
LockIDDeploymentSetup = iota + 1
|
||||||
LockIDEnterpriseDeploymentSetup
|
LockIDEnterpriseDeploymentSetup
|
||||||
LockIDDBRollup
|
LockIDDBRollup
|
||||||
|
LockIDDBPurge
|
||||||
)
|
)
|
||||||
|
|
||||||
// GenLockID generates a unique and consistent lock ID from a given string.
|
// GenLockID generates a unique and consistent lock ID from a given string.
|
||||||
|
|
Loading…
Reference in New Issue