Add Vale checks to project

- Adds error-only configution.
- Makes check part of CI pipeline.
- Fixes errors in content.
This commit is contained in:
Evan Read 2020-03-18 06:38:21 +00:00 committed by Marcel Amirault
parent 7b133f65db
commit 9a73f9fbb2
23 changed files with 97 additions and 36 deletions

9
.vale.ini Normal file
View File

@ -0,0 +1,9 @@
# Vale configuration file.
#
# For more information, see https://errata-ai.gitbook.io/vale/getting-started/configuration.
StylesPath = doc/.vale
MinAlertLevel = suggestion
[*.md]
BasedOnStyles = gitlab

View File

@ -0,0 +1,11 @@
---
# Checks that internal links have .md extenstion and not .html extension.
#
# For a list of all options, see https://errata-ai.github.io/vale/styles/
extends: existence
message: Link %s must use the .md file extension.
link: https://docs.gitlab.com/ee/development/documentation/styleguide.html#links-to-internal-documentation
level: error
scope: raw
raw:
- '\[.+\]\((https?:){0}[\w\/\.-]+(\.html).*\)'

View File

@ -0,0 +1,11 @@
---
# Checks for the presence of absolute hyperlinks that should be relative.
#
# For a list of all options, see https://errata-ai.github.io/vale/styles/
extends: existence
message: Link %s must be relative.
link: https://docs.gitlab.com/ee/development/documentation/styleguide.html#links-to-internal-documentation
level: error
scope: raw
raw:
- '\[.+\]\(https?:\/\/docs\.gitlab\.com\/omnibus.*\)'

View File

@ -0,0 +1,15 @@
---
# Checks for the following in common content scenarios:
#
# - No spaces.
# - More than one space.
#
# For a list of all options, see https://errata-ai.github.io/vale/styles/
extends: existence
message: '"%s" must contain one and only one space.'
link: https://docs.gitlab.com/ee/development/documentation/styleguide.html#punctuation
level: error
nonword: true
tokens:
- '[a-z][.?!,][A-Z]'
- '[\w.?!,\(\)\-":] {2,}[\w.?!,\(\)\-":]'

View File

@ -0,0 +1,13 @@
---
# Checks for use of some of the top misused terms at GitLab.
#
# For a list of all options, see https://errata-ai.github.io/vale/styles/
extends: substitution
message: Use "%s" instead of "%s".
link: https://about.gitlab.com/handbook/communication/#top-misused-terms
level: error
ignorecase: true
swap:
GitLabber: GitLab team member
self hosted: self-managed
self-hosted: self-managed

View File

@ -33,9 +33,9 @@ This section describes the commonly used configuration settings. Check
- [Installing GitLab](https://about.gitlab.com/install/)
- [Manually downloading and installing a GitLab package](manual_install.md)
- [Setting up a domain name/URL](https://docs.gitlab.com/omnibus/settings/configuration.html#configuring-the-external-url-for-gitlab) for the GitLab Instance so that it can be accessed easily
- [Enabling HTTPS](https://docs.gitlab.com/omnibus/settings/nginx.html#enable-https)
- [Enabling notification emails](https://docs.gitlab.com/omnibus/settings/smtp.html#smtp-settings)
- [Setting up a domain name/URL](settings/configuration.md#configuring-the-external-url-for-gitlab) for the GitLab Instance so that it can be accessed easily
- [Enabling HTTPS](settings/nginx.md#enable-https)
- [Enabling notification emails](settings/smtp.md#smtp-settings)
- [Enabling replying via email](https://docs.gitlab.com/ee/administration/reply_by_email.html#set-it-up)
- [Installing and configuring postfix](https://docs.gitlab.com/ee/administration/reply_by_email_postfix_setup.html)
- [Enabling container registry on GitLab](https://docs.gitlab.com/ee/administration/packages/container_registry.html#container-registry-domain-configuration)
@ -74,8 +74,8 @@ to work best with the available resources. Check out the [documentation](setting
- [Changing the name of the Git user group](settings/configuration.md#changing-the-name-of-the-git-user--group)
- [Specify numeric user and group identifiers](settings/configuration.md#specify-numeric-user-and-group-identifiers)
- [Only start Omnibus GitLab services after a given filesystem is mounted](settings/configuration.md#only-start-omnibus-gitlab-services-after-a-given-filesystem-is-mounted)
- [Disable user and group account management](settings/configuration.html#disable-user-and-group-account-management)
- [Disable storage directory management](settings/configuration.html#disable-storage-directories-management)
- [Disable user and group account management](settings/configuration.md#disable-user-and-group-account-management)
- [Disable storage directory management](settings/configuration.md#disable-storage-directories-management)
- [Configuring Rack attack](settings/configuration.md#configuring-rack-attack)
- [SMTP](settings/smtp.md)
- [NGINX](settings/nginx.md)

View File

@ -222,7 +222,7 @@ Keep in mind that the Git user must have access to the system so please review
your security settings at `/etc/security/access.conf` and make sure the Git user
is not blocked.
## Postgres error 'FATAL: could not create shared memory segment: Cannot allocate memory'
## Postgres error `FATAL: could not create shared memory segment: Cannot allocate memory`
The packaged Postgres instance will try to allocate 25% of total memory as
shared memory. On some Linux (virtual) servers, there is less shared memory
@ -245,7 +245,7 @@ postgresql['shared_buffers'] = "100MB"
Run `sudo gitlab-ctl reconfigure` for the change to take effect.
## Postgres error 'FATAL: could not open shared memory segment "/PostgreSQL.XXXXXXXXXX": Permission denied'
## Postgres error `FATAL: could not open shared memory segment "/PostgreSQL.XXXXXXXXXX": Permission denied`
By default, Postgres will try to detect the shared memory type to use. If you don't
have shared memory enabled, you might see this error in `/var/log/gitlab/postgresql/current`.
@ -380,7 +380,7 @@ Redis, Mattermost) are isolated from each other using Unix user
accounts. Creating and managing these user accounts requires root
access. By default, Omnibus GitLab will create the required Unix
accounts during `gitlab-ctl reconfigure` but that behavior can be
[disabled](../settings/configuration.html#disable-user-and-group-account-management).
[disabled](../settings/configuration.md#disable-user-and-group-account-management).
In principle Omnibus GitLab could do with only 2 user accounts (one
for GitLab and one for Mattermost) if we give each application its own

View File

@ -33,10 +33,10 @@ With the desired package downloaded, use your systems package management tool to
Change `http://gitlab.example.com` to the URL at which you want to access your GitLab instance. Installation will automatically configure and start GitLab at that URL.
> **Note:** Enabling HTTPS will require [additional configuration](settings/nginx.html#enable-https) to specify the certificates.
> **Note:** Enabling HTTPS will require [additional configuration](settings/nginx.md#enable-https) to specify the certificates.
## Browse to the hostname and login
On your first visit, you'll be redirected to a password reset screen. Provide the password for the initial administrator account and you will be redirected back to the login screen. Use the default account's username `root` to login.
See our [documentation for detailed instructions on installing and configuration](https://docs.gitlab.com/omnibus/README.html#installation-and-configuration-using-omnibus-package).
See our [documentation for detailed instructions on installing and configuration](README.md#installation-and-configuration-using-omnibus-package).

View File

@ -782,9 +782,9 @@ systems `sudo service nginx restart`).
Make sure you don't have the `proxy_set_header` configuration in
`nginx['custom_gitlab_server_config']` settings and instead use the
['proxy_set_headers'](https://docs.gitlab.com/omnibus/settings/nginx.html#supporting-proxied-ssl) configuration in your `gitlab.rb` file.
['proxy_set_headers'](#supporting-proxied-ssl) configuration in your `gitlab.rb` file.
### javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
### `javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure`
Starting with GitLab 10, the Omnibus GitLab package no longer supports TLSv1 protocol by default.
This can cause connection issues with some older Java based IDE clients when interacting with

View File

@ -15,7 +15,7 @@ Administrators can enable secure http using any method supported by a GitLab ser
|-|-|-|
| Primary GitLab Instance Domain | [Yes](nginx.md#manually-configuring-https) | [Yes](#lets-encrypt-integration) |
| Container Registry | [Yes](https://docs.gitlab.com/ee/administration/packages/container_registry.html#configure-container-registry-under-its-own-domain) | [Yes](#lets-encrypt-integration) |
| Mattermost | [Yes](https://docs.gitlab.com/omnibus/gitlab-mattermost/README.html#running-gitlab-mattermost-with-https) | [Yes](#lets-encrypt-integration) |
| Mattermost | [Yes](../gitlab-mattermost/README.md#running-gitlab-mattermost-with-https) | [Yes](#lets-encrypt-integration) |
| GitLab Pages | [Yes](https://docs.gitlab.com/ee/administration/pages/#wildcard-domains-with-tls-support) | No |
### Let's Encrypt Integration

View File

@ -3,7 +3,7 @@
From version 10.0 GitLab requires the version of PostgreSQL to be 9.6 or
higher.
Check out [docs on upgrading packaged PostgreSQL server](https://docs.gitlab.com/omnibus/settings/database.html#upgrade-packaged-postgresql-server)
Check out [docs on upgrading packaged PostgreSQL server](../settings/database.md#upgrade-packaged-postgresql-server)
for details.
- For users running versions below 8.15 and using PostgreSQL bundled with

View File

@ -45,14 +45,14 @@ been removed:
1. Mattermost related configurations - Support for most of the Mattermost
related configuration have been removed, except for the essential ones that
are needed for GitLab-Mattermost integration. [Check out the official documentation for details](https://docs.gitlab.com/omnibus/gitlab-mattermost/#upgrading-gitlab-mattermost-from-versions-prior-to-11-0)
are needed for GitLab-Mattermost integration. [Check out the official documentation for details](../gitlab-mattermost/README.md#upgrading-gitlab-mattermost-from-versions-prior-to-110)
1. Legacy `git_data_dir` configuration, which was used to set location of where
data was to be stored. It has been now replaced with `git_data_dirs`
configuration. [Check out the official documentation for details](https://docs.gitlab.com/omnibus/settings/configuration.html#storing-git-data-in-an-alternative-directory)
configuration. [Check out the official documentation for details](../settings/configuration.md#storing-git-data-in-an-alternative-directory)
1. Old format of `git_data_dirs` configuration has been replaced with a new
format, allowing much more fine grain control. [Check out the official documentation for details](https://docs.gitlab.com/omnibus/settings/configuration.html#storing-git-data-in-an-alternative-directory)
format, allowing much more fine grain control. [Check out the official documentation for details](../settings/configuration.md#storing-git-data-in-an-alternative-directory)
## Changes introduced in minor versions

View File

@ -8,7 +8,7 @@ When upgrading to a new major version, remember to first [check for background m
Prometheus 1.x was deprecated in GitLab 11.4, and
Prometheus 2.8.1 was installed by default on new installations. Users updating
from older versions of GitLab could manually upgrade Prometheus data using the
[`gitlab-ctl prometheus-upgrade`](https://docs.gitlab.com/omnibus/update/gitlab_11_changes.html#114)
[`gitlab-ctl prometheus-upgrade`](gitlab_11_changes.md#114)
command provided. You can view current Prometheus version in use from the
instances Prometheus `/status` page.
@ -16,7 +16,7 @@ With GitLab 12.0, support for Prometheus 1.x is completely removed, and as part
of the upgrade process, Prometheus binaries will be updated to version 2.8.1.
Existing data from Prometheus 1.x installation WILL NOT be migrated as part of
this automatic upgrade, and users who wish to retain that data should
[manually upgrade Prometheus version](https://docs.gitlab.com/omnibus/update/gitlab_11_changes.html#114)
[manually upgrade Prometheus version](gitlab_11_changes.md#114)
before upgrading to GitLab 12.0
For users who use `/etc/gitlab/skip-auto-reconfigure` file to skip automatic
@ -110,7 +110,7 @@ ones at the earliest.
The Redis version packaged with Omnibus GitLab has been updated to Redis 5.0.7.
You will need to restart Redis after the upgrade so that the new version will be
active. To restart Redis, run `sudo gitlab-ctl restart redis`. If your instance
has Redis HA with Sentinel, follow the upgrade steps documented in [Updating GitLab installed with the Omnibus GitLab package](https://docs.gitlab.com/omnibus/update/README.html#using-redis-ha-using-sentinel)
has Redis HA with Sentinel, follow the upgrade steps documented in [Updating GitLab installed with the Omnibus GitLab package](README.md#using-redis-ha-using-sentinel)
to avoid downtime.
### 12.8

View File

@ -135,6 +135,8 @@ docs-lint:
before_script: []
<<: *dedicated-runner
script:
# Lint prose
- vale --minAlertLevel error doc
# Lint Markdown
- markdownlint --config .markdownlint.json 'doc/**/*.md'
# Prepare docs for build