cli/.gitlab/issue_templates/Maintainer Onboarding.md

3.2 KiB

Basic setup

Code Review Pairing

Much like pair programming, pairing on code review is a great way to knowledge share and collaborate on merge request. This is a great activity for trainee maintainers to participate with maintainers for learning their process of code review.

A private code review session (unrecorded) involves one primary reviewer, and a shadow. If more than one shadow wishes to observe a private session, please consider obtaining consent from the merge request author.

A public code review session involves a primary reviewer and one or more shadows in a recorded session that is released publicly, for example to GitLab Unfiltered.

  • If the merge request author is a GitLab team member, please consider obtaining consent from them.
  • If the merge request author is a community contributor, you must obtain consent from them.
  • Do not release reviews of security merge requests publicly.

When you're ready to make it official

When reviews have accumulated, you can confidently address the majority of the MR's assigned to you, and recent reviews consistently fulfill maintainer responsibilities, then you can propose yourself as a new maintainer for the relevant application.

Remember that even when you are a maintainer, you can still request help from other maintainers if you come across an MR that you feel is too complex or requires a second opinion.

If you need assistance with any of the following steps, ask in either the #f_cli Slack channel.

  • Create a merge request updating your team member entry proposing yourself as a maintainer for the gitlab-cli project, assigned to your manager.
  • Ask an existing maintainer to give you the Maintainer role in this GitLab project.
  • Keep reviewing, start merging 🤘