Merge branch 'fix-nginx-restart-listen-address' into 'master'

Restart nginx instead of issuing HUP to ensure changes in listen_address work

If a user changes `listen_address`, nginx won't change its bindings with a HUP signal. Do a full restart to ensure all changes are used.

Issue #378

See merge request !298

CHANGELOG.md

@@ -5,10 +5,11 @@ omnibus-gitlab repository.
 
 7.9.0
 
+- Restart nginx instead of issuing a HUP signal changes so that changes in listen_address work (Stan Hu) 428ee157c346f3f0eae53762b51145502b1456a6
 - Respect gitlab_email_enabled property (Daniel Serodio) e2982692d49772c4f896a775e476a62b4831b8a1
 - Use correct cert for CI (Flávio J. Saraiva) 484227e2dfe33f59e3683a5757be6842d7ce79d2
 - Add ca_path and ca_file params for smtp email configuration (Thireus) fa9c1464bc1eb173660edfded1a2f7add7ac24b3
-- Add custom listen_port to nginx config for reverse proxies (Stan Hu) 8c438a68fb155bd3489c32a1478484ccfd9b3ffb 
+- Add custom listen_port to nginx config for reverse proxies (Stan Hu) 8c438a68fb155bd3489c32a1478484ccfd9b3ffb
 - Update openssl to 1.0.1k 0aa00aecf0867e5d454ebf089cb3a23d4645632c
 - DEPRECATION: 'gitlab_signup_enabled', 'gitlab_signin_enabled', 'gitlab_default_projects_limit', 'gravatar_enabled' are deprecated, settings can be changed in admin section of GitLab UI
 - DEPRECATION: CI setting `gitlab_ci_add_committer` is deprecated. Use `gitlab_ci_add_pusher` to notify user who pushed the commit of a failing build

files/gitlab-cookbooks/gitlab/recipes/nginx.rb

@@ -102,7 +102,6 @@ end
 
 runit_service "nginx" do
   down node['gitlab']['nginx']['ha']
-  restart_command 'h' # Restart NGINX using SIGHUP
   options({
     :log_directory => nginx_log_dir
   }.merge(params))