selfhosted
/
coder
mirror of https://github.com/coder/coder.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
coder/coderd
History
Spike Curtis dfe8efc186
fix: use background context for inmem provisionerd (#11545) 
This test case fails with an error log, showing "context canceled" when trying to send an acquired job to an in-mem provisionerd.

https://github.com/coder/coder/runs/20331469006

In this case, we don't want to supress this error, since it could mean that we acquired a job, locked it in the database, then failed to send it to a provisioner.
(We also don't want to mark the job as failed because we don't know whether the job made it to the provisionerd or not --- in the failed test you can see that the job is actually processed just fine).

The reason we got context canceled is because the API was shutting down --- we don't want provisionerdserver to abruptly stop processing job stuff as the API shuts down as this will leave jobs in a bad state.  This PR fixes up the use of contexts with provisionerdserver and the associated drpc service calls.
 		2024-01-10 15:29:57 +04:00
..
agentapi feat(cli): add `coder open vscode` (#11191) 2024-01-02 20:46:18 +02:00
apidoc docs: remove empty page (#11511) 2024-01-09 12:52:45 +01:00
apikey chore: enable exhaustruct linter for database param structs (#9995) 2023-10-03 09:23:45 +01:00
audit chore(Makefile): use linter version from dogfood Dockerfile (#11147) 2023-12-12 10:02:32 +00:00
autobuild chore(coderd/autobuild): wait for active template version and inactive template version (#11210) 2023-12-14 13:58:57 +00:00
awsidentity fix: add new aws regions to instance identity (#10434) 2023-10-30 19:44:29 +00:00
azureidentity fix: test for expiry 3 months on Azure certs (#11362) 2024-01-02 09:30:36 +04:00
batchstats feat: add AgentAPI using DRPC (#10811) 2023-12-18 22:53:28 +10:00
coderdtest fix: use background context for inmem provisionerd (#11545) 2024-01-10 15:29:57 +04:00
database chore: update sqlc to 1.25.0 (#11538) 2024-01-10 09:19:41 +03:00
devtunnel chore: fix flake in tunnel (#9746) 2023-09-19 18:54:56 +00:00
externalauth feat: implement bitbucket-server external auth defaults (#10520) 2023-11-08 11:05:51 -06:00
gitsshkey chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
healthcheck fix(coderd/healthcheck): ignore deleted wsproxies in wsproxy healthcheck (#11515) 2024-01-09 16:36:26 +00:00
httpapi feat: add OAuth2 applications (#11197) 2023-12-21 21:38:42 +00:00
httpmw fix: relax csrf to exclude path based apps (#11430) 2024-01-08 22:33:57 +00:00
metricscache fix: lower amount of cached timezones for deployment daus (#11196) 2023-12-13 16:50:29 -06:00
oauthpki chore(Makefile): use linter version from dogfood Dockerfile (#11147) 2023-12-12 10:02:32 +00:00
parameter chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
prometheusmetrics fix: fix MetricsAggregator check for metric sameness (#11508) 2024-01-09 15:21:30 +04:00
provisionerdserver fix: stop logging error on canceled query (#11506) 2024-01-09 14:38:56 +04:00
rbac feat: add OAuth2 applications (#11197) 2023-12-21 21:38:42 +00:00
schedule feat: add server flag to disable user custom quiet hours (#11124) 2023-12-15 19:33:51 +10:00
searchquery feat: show dormant workspaces by default (#11053) 2023-12-07 18:09:35 -06:00
telemetry chore: add additional fields to license telemetry (#11173) 2023-12-14 15:52:52 -06:00
testdata/insights feat!: add `sections` parameter to template insights (#10010) 2023-10-03 15:44:50 +02:00
tracing feat: allow external services to be authable (#9996) 2023-10-03 14:04:39 +00:00
unhanger chore: compute job status as column (#10024) 2023-10-04 20:57:46 -05:00
updatecheck chore: rename dbfake to dbmem (#10432) 2023-10-30 17:42:20 +00:00
userpassword chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
util feat(coderd): add provisioner_daemons to /debug/health endpoint (#11393) 2024-01-08 09:29:04 +00:00
workspaceapps feat: add debug endpoint for single tailnet (#10485) 2023-11-13 17:14:12 -06:00
wsbuilder chore: mockgen archived, moved to new location (#11415) 2024-01-04 18:35:56 -06:00
wsconncache chore: rename Coordinator to CoordinatorV1 (#11222) 2023-12-15 11:38:12 +04:00
activitybump_test.go feat!: bump workspace activity by 1 hour (#10704) 2023-11-15 09:42:27 -06:00
apikey.go feat(coderd/database): generate foreign key constraints and add database.IsForeignKeyViolation (#9657) 2023-09-13 13:28:46 +01:00
apikey_test.go refactor(coderd/database): split `Time` and `Now` into `dbtime` package (#9482) 2023-09-01 16:50:12 +00:00
apiroot.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
audit.go chore: update audit log api docs (#10486) 2023-11-02 16:12:38 +00:00
audit_test.go chore: rename `AwaitTemplateVersionJobCompleted` and `AwaitWorkspaceBuildJobCompleted` (#10003) 2023-10-03 11:02:56 -06:00
authorize.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
authorize_test.go chore: rename `AwaitTemplateVersionJobCompleted` and `AwaitWorkspaceBuildJobCompleted` (#10003) 2023-10-03 11:02:56 -06:00
client_test.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
coderd.go fix: use background context for inmem provisionerd (#11545) 2024-01-10 15:29:57 +04:00
coderd_test.go fix: relax csrf to exclude path based apps (#11430) 2024-01-08 22:33:57 +00:00
csp.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
debug.go fix(coderd/debug): fix caching issue with dismissed sections (#11051) 2023-12-06 08:38:03 +00:00
debug_test.go fix(coderd/debug): fix caching issue with dismissed sections (#11051) 2023-12-06 08:38:03 +00:00
deployment.go feat: include server agent API version in buildinfo (#11057) 2023-12-08 12:50:25 +04:00
deployment_test.go feat(coderd): connect dbcrypt package implementation (#9523) 2023-09-07 15:49:49 +01:00
deprecated.go feat(coderd): add support for sending batched agent metadata (#10223) 2023-10-13 16:37:55 +03:00
experiments.go feat: add all safe experiments to the deployment page (#10276) 2023-10-17 14:49:19 -04:00
experiments_test.go feat: add all safe experiments to the deployment page (#10276) 2023-10-17 14:49:19 -04:00
externalauth.go feat: add user/settings page for managing external auth (#10945) 2023-12-06 08:41:45 -06:00
externalauth_test.go feat: add endpoints to list all authed external apps (#10944) 2023-12-05 14:03:44 -06:00
files.go refactor(coderd/database): split `Time` and `Now` into `dbtime` package (#9482) 2023-09-01 16:50:12 +00:00
files_test.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
gitsshkey.go refactor(coderd/database): split `Time` and `Now` into `dbtime` package (#9482) 2023-09-01 16:50:12 +00:00
gitsshkey_test.go chore: rename `AwaitTemplateVersionJobCompleted` and `AwaitWorkspaceBuildJobCompleted` (#10003) 2023-10-03 11:02:56 -06:00
insights.go chore: make `"users"."avatar_url"` `NOT NULL` (#11112) 2023-12-11 10:09:51 -07:00
insights_internal_test.go fix: pass in time parameter to prevent flakes (#11023) 2023-12-04 12:20:22 -05:00
insights_test.go feat: add AgentAPI using DRPC (#10811) 2023-12-18 22:53:28 +10:00
latencycheck.go chore: add prometheus timing to latency endpoint (#7742) 2023-06-06 10:26:13 -05:00
members.go fix: stop leaking User into API handlers unless authorized 2023-10-11 09:41:14 +04:00
organizations.go chore: enable exhaustruct linter for database param structs (#9995) 2023-10-03 09:23:45 +01:00
organizations_test.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
pagination.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
pagination_internal_test.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
provisionerjobs.go feat: add AgentAPI using DRPC (#10811) 2023-12-18 22:53:28 +10:00
provisionerjobs_internal_test.go chore: mockgen archived, moved to new location (#11415) 2024-01-04 18:35:56 -06:00
provisionerjobs_test.go chore: rename `AwaitTemplateVersionJobCompleted` and `AwaitWorkspaceBuildJobCompleted` (#10003) 2023-10-03 11:02:56 -06:00
roles.go chore: add display name to member role (#10239) 2023-10-12 10:52:32 -05:00
roles_test.go chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133) 2023-10-10 11:14:20 +01:00
tailnet.go feat: add debug endpoint for single tailnet (#10485) 2023-11-13 17:14:12 -06:00
tailnet_test.go feat: add server flag to force DERP to use always websockets (#9238) 2023-08-24 17:22:31 +00:00
templates.go chore: deprecate template create command in favor of template push (#11390) 2024-01-05 21:04:14 +00:00
templates_test.go feat: allow templates to specify max_ttl or autostop_requirement (#10920) 2023-12-15 18:27:56 +10:00
templateversions.go chore: make `"users"."avatar_url"` `NOT NULL` (#11112) 2023-12-11 10:09:51 -07:00
templateversions_test.go chore(coderd): move provisionerd tags to provisionersdk (#11100) 2023-12-08 12:10:25 +00:00
updatecheck.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
updatecheck_test.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
userauth.go chore: make `"users"."avatar_url"` `NOT NULL` (#11112) 2023-12-11 10:09:51 -07:00
userauth_internal_test.go feat: allow IDP to return single string for roles/groups claim (#10993) 2023-12-04 10:01:45 -06:00
userauth_test.go fix: make 'NoRefresh' honor unlimited tokens in gitauth (#9472) 2023-09-05 09:08:04 -05:00
users.go feat: add a theme picker (#11140) 2023-12-14 10:38:44 -07:00
users_test.go fix: use database for user creation to prevent flake (#10992) 2023-12-04 11:05:17 -05:00
workspaceagents.go chore(coderd): extract api version validation to util package (#11407) 2024-01-05 10:22:07 +00:00
workspaceagents_test.go feat: add tailnet v2 API support to coordinate endpoint (#11228) 2023-12-15 14:10:24 +04:00
workspaceagentsrpc.go chore: refactor agent connection updates (#11301) 2024-01-02 16:04:37 +04:00
workspaceagentsrpc_internal_test.go chore(coderd): fix test flake in TestAgentWebsocketMonitor_SendPings (#11518) 2024-01-10 08:45:46 +00:00
workspaceapps.go refactor(coderd/database): split `Time` and `Now` into `dbtime` package (#9482) 2023-09-01 16:50:12 +00:00
workspaceapps_test.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
workspacebuilds.go feat: add AgentAPI using DRPC (#10811) 2023-12-18 22:53:28 +10:00
workspacebuilds_test.go chore(coderd): fix test flake with auditor (#11316) 2023-12-22 09:50:49 +00:00
workspaceproxies.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
workspaceproxies_test.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
workspaceresourceauth.go chore: add /v2 to import module path (#9072) 2023-08-18 18:55:43 +00:00
workspaceresourceauth_test.go chore: rename `AwaitTemplateVersionJobCompleted` and `AwaitWorkspaceBuildJobCompleted` (#10003) 2023-10-03 11:02:56 -06:00
workspaces.go fix(site): fix error when loading workspaces with dormant (#11291) 2023-12-19 20:42:07 -03:00
workspaces_test.go chore(coderd): fix test flake in TestWorkspaceUpdateAutomaticUpdates_OK (#11521) 2024-01-10 08:45:32 +00:00