coder/coderd
Ammar Bandukwala 4b9621f9ae
fix(coderd): don't hang on first gitauth clone (#7331)
Previously, the `coder git ssh` command would hang on the API, which was endlessly polling the database for oauth tokens that expire in the future.

Some oAuth implementations (including GitHub by default) will not give back a token expiry date, and the absence of such a date was represented as a zero data in the database as opposed to a null value.

Follow-up calls to `git clone` would succeed because this hot path doesn't check expiry, perhaps originally by mistake.

In addition to fixing the zero date issue, this PR removes all gitauth PubSub, which added too much complexity when the polling interval is 1 second.
2023-05-01 19:19:41 +00:00
..
apidoc feat: Implement aggregator for agent metrics (#7259) 2023-04-27 12:34:00 +02:00
audit feat: differentiate new user registration from user login in the audit log (#7096) 2023-04-12 11:46:16 -07:00
autobuild Revert "fix: change auto-start to automatically update workspaces (#6053)" (#7084) 2023-04-11 14:14:35 +00:00
awsidentity chore: format Go more aggressively 2023-02-18 18:32:09 -06:00
azureidentity fix: add more cached certificates to azure instance identity (#6519) 2023-03-08 19:32:10 -06:00
coderdtest test: Fix generated workspace name length (#7228) 2023-04-20 18:40:36 +00:00
database fix(coderd): ensure that user API keys are deleted when a user is (#7270) 2023-04-24 21:48:26 +01:00
devtunnel chore: switch to new wgtunnel via tunnelsdk (#6489) 2023-03-22 13:13:48 +00:00
gitauth feat: pass `access_token` to `coder_git_auth` resource (#6713) 2023-03-22 19:37:08 +00:00
gitsshkey feat: convert entire CLI to clibase (#6491) 2023-03-23 17:42:20 -05:00
healthcheck fix(healthcheck): don't allow panics to exit coderd (#7276) 2023-04-25 15:11:45 +00:00
httpapi chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
httpmw fix: vite fatals on receiving HTTP4xx (#7306) 2023-04-27 19:04:24 +02:00
metricscache feat: add startup script logs to the ui (#6558) 2023-03-23 14:09:13 -05:00
parameter chore: Use dbgen in unit test (#6111) 2023-02-08 13:47:05 -06:00
prometheusmetrics feat: Implement aggregator for agent metrics (#7259) 2023-04-27 12:34:00 +02:00
provisionerdserver feat(scaletest): allow scaletests to run using the host credentials (#7075) 2023-04-11 19:49:28 +00:00
rbac chore: fix deadlock in dbfake and incorrect lock types (#7218) 2023-04-20 21:53:34 +10:00
schedule feat: allow disabling autostart and custom autostop for template (#6933) 2023-04-04 12:48:35 +00:00
searchquery feat: Guard search queries against common mistakes (#6404) 2023-03-01 23:28:56 -06:00
telemetry feat: add workspace agent stat reporting to telemetry (#6577) 2023-03-13 14:16:54 -05:00
tracing chore: update otel to v1.14.0 (#6963) 2023-04-03 00:31:39 -05:00
updatecheck chore: rename "InsertOrUpdate" to Upsert around the codebase (#6823) 2023-03-28 00:55:10 +00:00
userpassword feat: add minimum password entropy requirements (#6090) 2023-02-08 14:10:08 -06:00
util fix(audit): ensure template creation errors are audited (#7315) 2023-04-27 18:55:34 -05:00
workspaceapps chore: UI/UX for regions (#7283) 2023-04-28 16:04:52 -05:00
wsconncache chore: tailnet debug logging (#7260) 2023-04-27 13:59:01 +04:00
activitybump.go feat: add template max_ttl (#6114) 2023-03-07 14:14:58 +00:00
activitybump_test.go chore: move workspace apps tests to new package (#7025) 2023-04-06 16:35:27 -05:00
apikey.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
apikey_test.go fix(coderd): ensure that user API keys are deleted when a user is (#7270) 2023-04-24 21:48:26 +01:00
apiroot.go docs: api root, buildinfo, csp (#5493) 2022-12-22 15:53:14 +01:00
audit.go feat: differentiate new user registration from user login in the audit log (#7096) 2023-04-12 11:46:16 -07:00
audit_test.go feat: Guard search queries against common mistakes (#6404) 2023-03-01 23:28:56 -06:00
authorize.go chore: add workspace proxies to the backend (#7032) 2023-04-17 19:57:21 +00:00
authorize_test.go feat: Option to remove WorkspaceExec from `owner` role (#7050) 2023-04-11 08:57:23 -05:00
client_test.go chore: move workspace apps tests to new package (#7025) 2023-04-06 16:35:27 -05:00
coderd.go feat: Implement aggregator for agent metrics (#7259) 2023-04-27 12:34:00 +02:00
coderd_test.go fix(tailnet): Skip nodes without DERP, avoid use of RemoveAllPeers (#6320) 2023-02-24 18:16:29 +02:00
csp.go feat: Validate swagger definitions (#5694) 2023-01-13 12:27:21 +01:00
debug.go feat(coderd): add DERP healthcheck (#6936) 2023-04-03 06:28:42 +00:00
debug_test.go feat(coderd): add DERP healthcheck (#6936) 2023-04-03 06:28:42 +00:00
deployment.go chore: add workspace proxies to the backend (#7032) 2023-04-17 19:57:21 +00:00
deployment_test.go feat: allow configuring OIDC email claim and OIDC auth url parameters (#6867) 2023-03-30 09:36:57 +01:00
experiments.go feat: add --experiments flag to replace --experimental (#5767) 2023-01-18 19:12:53 +00:00
experiments_test.go feat: refactor deployment config (#6347) 2023-03-07 15:10:01 -06:00
files.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
files_test.go Stream template upload (#6035) 2023-02-04 20:07:09 +00:00
gitsshkey.go feat: Dbauthz is now default, remove out of experimental (#6650) 2023-03-21 09:10:22 -05:00
gitsshkey_test.go chore: wrap audit logs in a mutex to fix data race (#6898) 2023-03-30 12:13:03 -05:00
insights.go feat: refactor deployment config (#6347) 2023-03-07 15:10:01 -06:00
insights_test.go fix: always show a newly created workspace at the top of the list (#6984) 2023-04-04 08:24:04 -05:00
members.go feat: Dbauthz is now default, remove out of experimental (#6650) 2023-03-21 09:10:22 -05:00
organizations.go feat: Dbauthz is now default, remove out of experimental (#6650) 2023-03-21 09:10:22 -05:00
organizations_test.go chore: remove `CreateAnotherUserWithUser` (#6068) 2023-02-06 23:48:21 +00:00
pagination.go feat: trace httpapi.{Read,Write} (#4134) 2022-09-21 17:07:00 -05:00
pagination_internal_test.go chore: Upgrade to Go 1.19 (#3617) 2022-08-21 22:32:53 +00:00
parameters.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
parameters_test.go Refactor Provisioner to distinguish Plan and Apply (#5036) 2022-11-11 16:45:58 -06:00
provisionerjobs.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
provisionerjobs_internal_test.go feat: Add buffering to provisioner job logs (#4918) 2022-11-06 20:50:34 -06:00
provisionerjobs_test.go feat: add startup script logs to the ui (#6558) 2023-03-23 14:09:13 -05:00
roles.go feat: Add initial AuthzQuerier implementation (#5919) 2023-02-14 14:27:06 +00:00
roles_test.go feat: Add initial AuthzQuerier implementation (#5919) 2023-02-14 14:27:06 +00:00
templates.go fix(audit): ensure template creation errors are audited (#7315) 2023-04-27 18:55:34 -05:00
templates_test.go feat: allow disabling autostart and custom autostop for template (#6933) 2023-04-04 12:48:35 +00:00
templateversions.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
templateversions_test.go chore: wrap audit logs in a mutex to fix data race (#6898) 2023-03-30 12:13:03 -05:00
updatecheck.go docs: api root, buildinfo, csp (#5493) 2022-12-22 15:53:14 +01:00
updatecheck_test.go feat: convert entire CLI to clibase (#6491) 2023-03-23 17:42:20 -05:00
userauth.go feat: differentiate new user registration from user login in the audit log (#7096) 2023-04-12 11:46:16 -07:00
userauth_test.go fix(coderd): ensure that user API keys are deleted when a user is (#7270) 2023-04-24 21:48:26 +01:00
users.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
users_test.go fix(coderd): ensure that user API keys are deleted when a user is (#7270) 2023-04-24 21:48:26 +01:00
workspaceagents.go fix(coderd): don't hang on first gitauth clone (#7331) 2023-05-01 19:19:41 +00:00
workspaceagents_test.go chore(coderd): remove timing check (#7144) 2023-04-17 17:40:02 +00:00
workspaceapps.go chore: support signed token query param for web terminal (#7197) 2023-04-20 23:59:45 +00:00
workspaceapps_test.go chore: add workspace proxies to the backend (#7032) 2023-04-17 19:57:21 +00:00
workspacebuilds.go fix: coder_parameter fallbacks to default (#7240) 2023-04-24 09:51:34 +02:00
workspacebuilds_test.go fix: coder_parameter fallbacks to default (#7240) 2023-04-24 09:51:34 +02:00
workspaceproxies.go feat: add regions endpoint for proxies feature (#7277) 2023-04-25 09:37:52 -05:00
workspaceproxies_test.go feat: add regions endpoint for proxies feature (#7277) 2023-04-25 09:37:52 -05:00
workspaceresourceauth.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
workspaceresourceauth_test.go chore: move agent functions from `codersdk` into `agentsdk` (#5903) 2023-01-29 15:47:24 -06:00
workspaces.go chore: Rbac errors should be returned, and not hidden behind 404 (#7122) 2023-04-13 13:06:16 -05:00
workspaces_test.go test: Fix generated workspace name length (#7228) 2023-04-20 18:40:36 +00:00