9afad8241b
chore: add security advisories to docs ( #7282 )
...
* chore: add security advisories to docs
* Update docs/security/0001_user_apikeys_invalidation.md
Co-authored-by: Ammar Bandukwala <ammar@ammar.io>
---------
Co-authored-by: Ammar Bandukwala <ammar@ammar.io>
2023-04-25 16:56:09 +01:00
b62b6af0eb
fix(healthcheck): don't allow panics to exit coderd ( #7276 )
2023-04-25 15:11:45 +00:00
a98341612c
feat: add regions endpoint for proxies feature ( #7277 )
...
* feat: add regions endpoint for proxies feature
2023-04-25 09:37:52 -05:00
6e8ff2d95c
Fix macOS pty race with dropped output ( #7278 )
...
Signed-off-by: Spike Curtis <spike@coder.com>
2023-04-25 12:32:28 +04:00
e2d8bda246
chore(dogfood): remove unnecessary docker host replace ( #7269 )
2023-04-25 04:58:09 +00:00
8fc8559076
fix(coderd): ensure that user API keys are deleted when a user is ( #7270 )
...
Fixes an issue where API tokens belonging to a deleted user were
not invalidated:
- Adds a trigger to delete rows from the api_key stable when the
column deleted is set to true in the users table.
- Adds a trigger to the api_keys table to ensure that new rows
may not be added where user_id corresponds to a deleted user.
- Adds a migration to delete all API keys from deleted users.
- Adds tests + dbfake implementation for the above.
2023-04-24 21:48:26 +01:00
ad82a60806
refactor(site): Group app and agent actions together ( #7267 )
2023-04-24 16:59:52 -03:00
96a12d17ef
Revert "feat(UI): add workspace restart button ( #7137 )" ( #7268 )
...
This reverts commit 9ec16d4454
2023-04-24 12:44:22 -07:00
3129741e08
chore: Proxy health status checks + endpoint ( #7233 )
...
* chore: Implement workspace proxy health check cron
At a given interval will check the reachability of workspace proxies.
* Proxyhealth is an enterprise feature
* Start proxyhealth go routine on enterprise coder
2023-04-24 10:25:35 -05:00
63e68c11d1
feat(community-templates): Added vscode-server-template ( #7219 )
...
Co-authored-by: Kyle Carberry <kyle@carberry.com>
2023-04-24 15:22:18 +03:00
daee91c6dc
refactor: PTY & SSH ( #7100 )
...
* Add ssh tests for longoutput, orphan
Signed-off-by: Spike Curtis <spike@coder.com>
* PTY/SSH tests & improvements
Signed-off-by: Spike Curtis <spike@coder.com>
* Fix some tests
Signed-off-by: Spike Curtis <spike@coder.com>
* Fix linting
Signed-off-by: Spike Curtis <spike@coder.com>
* fmt
Signed-off-by: Spike Curtis <spike@coder.com>
* Fix windows test
Signed-off-by: Spike Curtis <spike@coder.com>
* Windows copy test
Signed-off-by: Spike Curtis <spike@coder.com>
* WIP Windows pty handling
Signed-off-by: Spike Curtis <spike@coder.com>
* Fix truncation tests
Signed-off-by: Spike Curtis <spike@coder.com>
* Appease linter/fmt
Signed-off-by: Spike Curtis <spike@coder.com>
* Fix typo
Signed-off-by: Spike Curtis <spike@coder.com>
* Rework truncation test to not assume OS buffers
Signed-off-by: Spike Curtis <spike@coder.com>
* Disable orphan test on Windows --- uses sh
Signed-off-by: Spike Curtis <spike@coder.com>
* agent_test running SSH in pty use ptytest.Start
Signed-off-by: Spike Curtis <spike@coder.com>
* More detail about closing pseudoconsole on windows
Signed-off-by: Spike Curtis <spike@coder.com>
* Code review fixes
Signed-off-by: Spike Curtis <spike@coder.com>
* Rearrange ptytest method order
Signed-off-by: Spike Curtis <spike@coder.com>
* Protect pty.Resize on windows from races
Signed-off-by: Spike Curtis <spike@coder.com>
* Fix windows bugs
Signed-off-by: Spike Curtis <spike@coder.com>
* PTY doesn't extend PTYCmd
Signed-off-by: Spike Curtis <spike@coder.com>
* Fix windows types
Signed-off-by: Spike Curtis <spike@coder.com>
---------
Signed-off-by: Spike Curtis <spike@coder.com>
2023-04-24 14:53:57 +04:00
c000f2ec28
fix: coder_parameter fallbacks to default ( #7240 )
2023-04-24 09:51:34 +02:00
ab077d1f15
docs: fixed broken podman template link and added already-installed ide gateway doc ( #6352 )
...
Co-authored-by: Eric Paulsen <ericpaulsen@coder.com>
2023-04-21 20:43:19 +00:00
712098fa2b
test(agent): Increase the time to wait for agent reachable ( #7245 )
2023-04-21 19:40:17 +00:00
501dfeedf7
fix: invalid version for `github.com/coder/ssh` ( #7250 )
2023-04-21 18:10:35 +00:00
1fc32b1c3d
ci: disable caching in setup/go action ( #7251 )
2023-04-21 13:01:42 -05:00
fd84df769d
fix: add `DISPLAY` env var for X11 connections ( #7248 )
...
* fix: add `DISPLAY` env var for X11 connections
* Update agent/agentssh/agentssh.go
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
---------
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
2023-04-21 16:43:49 +00:00
f9da2631e9
test(cli): Fix portforward test timeouts ( #7241 )
2023-04-21 11:40:31 -05:00
f39e6a79de
feat: add support for X11 forwarding ( #7205 )
...
* feat: add support for X11 forwarding
* Only run X forwarding on Linux
* Fix piping
* Fix comments
2023-04-21 15:52:40 +00:00
6f06f8dadb
test: Fix test timeouts due to contexts created too early ( #7242 )
2023-04-21 17:32:25 +03:00
ea78ca5dff
test(coderd/workspaceapps): Fix incorrect use of testing.T ( #7243 )
2023-04-21 17:32:10 +03:00
3680e158d9
chore: fix lint in main caused by incompatible merge ( #7239 )
2023-04-21 10:27:56 +00:00
4353ad7940
chore: Remove url and wildcard url from moon create ( #7224 )
...
* chore: Remove url and wildcard url from moon create
2023-04-20 21:09:14 -05:00
68667323f3
chore: support signed token query param for web terminal ( #7197 )
...
* chore: add endpoint to get token for web terminal
* chore: support signed token query param for web terminal
2023-04-20 23:59:45 +00:00
ac3c530283
fix(cli/clitest): race between `Start`/`StartWithWaiter` cleanup order ( #7232 )
2023-04-20 23:41:56 +00:00
745868fd8a
revert: chore: upgrade tailscale ( #7236 )
2023-04-20 17:58:22 -05:00
300ae4a6bf
test(agent): Fix TestAgent_UnixRemoteForwarding timeout ( #7235 )
2023-04-21 01:35:51 +03:00
38a6d546ab
fix(enterprise/replicasync): Avoid deadlock during Close^2 ( #7230 )
2023-04-20 22:48:44 +03:00
34c6ad671c
fix(clitest): use separate channel when waiting for exit ( #7231 )
2023-04-20 14:37:44 -05:00
ad0070354f
test: Fix generated workspace name length ( #7228 )
2023-04-20 18:40:36 +00:00
d8eda97dbe
refactor(site): Redesign the agent row ( #7226 )
2023-04-20 18:37:10 +00:00
a86830a283
chore: upgrade tailscale ( #7207 )
2023-04-20 13:29:56 -05:00
e2a7448cc8
fix: allow update of empty template description ( #7225 )
2023-04-20 10:59:57 -07:00
ea27129348
chore: upgrade `github.com/open-policy-agent/opa` ( #7204 )
2023-04-20 12:50:21 -05:00
e90a076fad
fix(site): Fix websocket connections ( #7187 )
2023-04-20 17:01:08 +00:00
7fa1112958
chore: Enforce workspace proxy unique name case insensitive ( #7202 )
...
* chore: Enforce workspace proxy unique name case insensitive
2023-04-20 11:30:52 -05:00
9abfe97dcc
Revert "fix(site): Fix update when missing parameters ( #7221 )" ( #7223 )
...
This reverts commit 7d9a7636e9
2023-04-20 12:40:31 -03:00
a5a5c4d400
chore: Add workspace proxy enterprise cli commands ( #7176 )
...
* feat: Add workspace proxy enterprise cli commands
* chore: Handle custom workspace proxy options. Remove excess
* chore: Add endpoint to register workspace proxies
2023-04-20 09:48:47 -05:00
8926c10b7d
chore: remove disk metadata from Kubernetes examples ( #7215 )
2023-04-20 09:42:35 -05:00
7d9a7636e9
fix(site): Fix update when missing parameters ( #7221 )
2023-04-20 09:32:20 -05:00
93d0956465
chore(site): Upgrade Vite to 4.3 ( #7222 )
2023-04-20 14:28:56 +00:00
8d27978760
fix(enterprise/replicasync): Avoid deadlock during Close ( #7220 )
2023-04-20 15:37:30 +03:00
528a0686c0
chore: fix deadlock in dbfake and incorrect lock types ( #7218 )
...
I manually went through every single dbfake function and ensured it has
the correct lock type depending on whether it writes or only reads.
There were a surprising amount of methods that had the wrong lock type
(Lock when only reading, or RLock when writing (!!!)).
This also manually fixes every method that acquires a RLock and then
calls a method that also acquires it's own RLock to use noLock methods
instead. You cannot rely on acquiring a RLock twice in the same
goroutine as RWMutex prioritizes any waiting Lock calls.
I tried writing a ruleguard rule for this but because of limitations in
ruleguard it doesn't seem possible.
2023-04-20 21:53:34 +10:00
5f5edb18b0
chore(healthcheck): fix DERP test flakes ( #7211 )
2023-04-19 20:03:05 -05:00
f60b5579a7
chore: remove usage of `k8s.io/utils/pointer` ( #7209 )
2023-04-19 15:53:47 -05:00
c2871e12aa
fix(cli/ssh): Avoid connection hang when workspace is stopped ( #7201 )
...
* fix(cli/ssh): Avoid connection hang when workspace is stopped
Two issues are addressed here:
1. We were not detecting disconnects due to waiting for Stdin to close
(disconnect would only propagate after entering input and failing to
write to the connection).
2. In other scenarios, where the connection drop is not detected, we now
also watch workspace status and drop the connection when a workspace
reaches the stopped state.
Fixes: https://github.com/coder/jetbrains-coder/issues/199
Refs: #6180 , #6175
2023-04-19 21:32:28 +03:00
fff2b1dc90
fix(cli): Fix postgres TDE failing version check ( #7203 )
2023-04-19 11:59:56 -05:00
2b9d12828a
cli: add --debug-http flag ( #7192 )
...
This makes it easier to help debug client issues.
2023-04-19 11:07:53 -05:00
f94ac55f02
feat(agent): Expose magicsock metrics ( #7183 )
...
* feat: Expose magicsock metrics
* golden-files
2023-04-19 09:09:23 +02:00
fbf329fbb7
fix(tailnet): set TCP keepalive idle to 72 hours for SSH conns ( #7196 )
2023-04-18 17:53:11 -05:00
Cian Johnston
Colin Adler
Dean Sheather
Spike Curtis
Bruno Quaresma
Kira Pilot
Steven Masley
Nathanial Spearing
Marcin Tojek
sharkymark
Mathias Fredriksson
Kyle Carberry
Muhammad Atif Ali
Marc
Ammar Bandukwala