selfhosted
/
coder
mirror of https://github.com/coder/coder.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: display tooltip when selection is disabled (#12439)

This commit is contained in:
Garrett Delfosse 2024-03-07 10:43:25 -05:00 committed by GitHub
parent 586586e9dd
commit d2a74cf547
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
site/src/modules/resources/PortForwardButton.tsx
View File

@ -14,6 +14,7 @@ import MenuItem from "@mui/material/MenuItem";
import Select from "@mui/material/Select";
import Stack from "@mui/material/Stack";
import TextField from "@mui/material/TextField";
import Tooltip from "@mui/material/Tooltip";
import { type FormikContextType, useFormik } from "formik";
import type { FC } from "react";
import { useQuery, useMutation } from "react-query";
@ -204,6 +205,23 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
const canSharePortsPublic =
canSharePorts && template.max_port_share_level === "public";
const publicMenuItem = (
<>
{canSharePortsPublic ? (
<MenuItem value="public">Public</MenuItem>
) : (
<Tooltip title="This workspace template does not allow sharing ports with unauthenticated users.">
{/* Tooltips don't work directly on disabled MenuItem components so you must wrap in div. */}
<div>
<MenuItem value="public" disabled>
Public
</MenuItem>
</div>
</Tooltip>
)}
</>
);
return (
<>
<div
@ -429,12 +447,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
<MenuItem value="authenticated">
Authenticated
</MenuItem>
<MenuItem
value="public"
disabled={!canSharePortsPublic}
>
Public
</MenuItem>
{publicMenuItem}
</Select>
</FormControl>
<Button
@ -499,9 +512,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
label="Sharing Level"
>
<MenuItem value="authenticated">Authenticated</MenuItem>
<MenuItem value="public" disabled={!canSharePortsPublic}>
Public
</MenuItem>
{publicMenuItem}
</TextField>
<LoadingButton
variant="contained"