From b20cb993bd3fd39b84591d6ca300cad1171db727 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Fri, 27 Jan 2023 09:37:55 -0600 Subject: [PATCH] fix: loop variable captured by func literal in parameters test (#5878) I noticed this when adding a new parameter type. There's a test case for an empty string that returned false for validation, but appears like it could be true. If there is no value for a string, then the default is used. In this case there is no default, but that's technically fine I believe. --- coderd/workspacebuilds_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/coderd/workspacebuilds_test.go b/coderd/workspacebuilds_test.go index 5caef361d5..7bb8e0a761 100644 --- a/coderd/workspacebuilds_test.go +++ b/coderd/workspacebuilds_test.go @@ -900,7 +900,7 @@ func TestWorkspaceBuildValidateRichParameters(t *testing.T) { {numberParameterName, "10", true, numberRichParameters}, {numberParameterName, "11", false, numberRichParameters}, - {stringParameterName, "", false, stringRichParameters}, + {stringParameterName, "", true, stringRichParameters}, {stringParameterName, "foobar", true, stringRichParameters}, {stringParameterName, "abcd", true, regexRichParameters}, @@ -912,6 +912,7 @@ func TestWorkspaceBuildValidateRichParameters(t *testing.T) { } for _, tc := range tests { + tc := tc t.Run(tc.parameterName+"-"+tc.value, func(t *testing.T) { t.Parallel()