feat(site): remove experiment deployment_health_page (#11572)

This commit is contained in:
Cian Johnston 2024-01-11 21:03:10 +00:00 committed by GitHub
parent 26f5ce63a8
commit 95fd0bb22b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 28 additions and 42 deletions

7
coderd/apidoc/docs.go generated
View File

@ -9108,10 +9108,13 @@ const docTemplate = `{
"codersdk.Experiment": {
"type": "string",
"enum": [
"deployment_health_page"
"example"
],
"x-enum-comments": {
"ExperimentExample": "This isn't used for anything."
},
"x-enum-varnames": [
"ExperimentDeploymentHealthPage"
"ExperimentExample"
]
},
"codersdk.ExternalAuth": {

View File

@ -8153,8 +8153,11 @@
},
"codersdk.Experiment": {
"type": "string",
"enum": ["deployment_health_page"],
"x-enum-varnames": ["ExperimentDeploymentHealthPage"]
"enum": ["example"],
"x-enum-comments": {
"ExperimentExample": "This isn't used for anything."
},
"x-enum-varnames": ["ExperimentExample"]
},
"codersdk.ExternalAuth": {
"type": "object",

View File

@ -2076,20 +2076,15 @@ func (c *Client) BuildInfo(ctx context.Context) (BuildInfoResponse, error) {
type Experiment string
const (
// Deployment health page
ExperimentDeploymentHealthPage Experiment = "deployment_health_page"
// Add new experiments here!
// ExperimentExample Experiment = "example"
ExperimentExample Experiment = "example" // This isn't used for anything.
)
// ExperimentsAll should include all experiments that are safe for
// users to opt-in to via --experimental='*'.
// Experiments that are not ready for consumption by all users should
// not be included here and will be essentially hidden.
var ExperimentsAll = Experiments{
ExperimentDeploymentHealthPage,
}
var ExperimentsAll = Experiments{}
// Experiments is a list of experiments.
// Multiple experiments may be enabled at the same time.

4
docs/api/general.md generated
View File

@ -563,7 +563,7 @@ curl -X GET http://coder-server:8080/api/v2/experiments \
> 200 Response
```json
["deployment_health_page"]
["example"]
```
### Responses
@ -600,7 +600,7 @@ curl -X GET http://coder-server:8080/api/v2/experiments/available \
> 200 Response
```json
["deployment_health_page"]
["example"]
```
### Responses

8
docs/api/schemas.md generated
View File

@ -2869,16 +2869,16 @@ AuthorizationObject can represent a "set" of objects, such as: all workspaces in
## codersdk.Experiment
```json
"deployment_health_page"
"example"
```
### Properties
#### Enumerated Values
| Value |
| ------------------------ |
| `deployment_health_page` |
| Value |
| --------- |
| `example` |
## codersdk.ExternalAuth

View File

@ -1813,8 +1813,8 @@ export const Entitlements: Entitlement[] = [
];
// From codersdk/deployment.go
export type Experiment = "deployment_health_page";
export const Experiments: Experiment[] = ["deployment_health_page"];
export type Experiment = "example";
export const Experiments: Experiment[] = ["example"];
// From codersdk/deployment.go
export type FeatureName =

View File

@ -3,18 +3,14 @@ import { useQuery } from "react-query";
import { deploymentStats } from "api/queries/deployment";
import { usePermissions } from "hooks/usePermissions";
import { DeploymentBannerView } from "./DeploymentBannerView";
import { useDashboard } from "../DashboardProvider";
import { health } from "api/queries/debug";
export const DeploymentBanner: FC = () => {
const dashboard = useDashboard();
const permissions = usePermissions();
const deploymentStatsQuery = useQuery(deploymentStats());
const healthQuery = useQuery({
...health(),
enabled:
dashboard.experiments.includes("deployment_health_page") &&
permissions.viewDeploymentValues,
enabled: permissions.viewDeploymentValues,
});
if (!permissions.viewDeploymentValues || !deploymentStatsQuery.data) {

View File

@ -18,11 +18,7 @@ export const Navbar: FC = () => {
const canViewDeployment = Boolean(permissions.viewDeploymentValues);
const canViewAllUsers = Boolean(permissions.readAllUsers);
const proxyContextValue = useProxy();
const dashboard = useDashboard();
const canViewHealth =
canViewDeployment &&
dashboard.experiments.includes("deployment_health_page");
const canViewHealth = canViewDeployment;
return (
<NavbarView
user={me}

View File

@ -40,7 +40,7 @@ const meta: Meta<typeof GeneralSettingsPageView> = {
},
],
deploymentDAUs: MockDeploymentDAUResponse,
safeExperiments: ["deployment_health_page"],
safeExperiments: [],
},
};
@ -102,6 +102,6 @@ export const allExperimentsEnabled: Story = {
hidden: false,
},
],
safeExperiments: ["deployment_health_page"],
safeExperiments: [],
},
};

View File

@ -9,7 +9,6 @@ import VpnKeyOutlined from "@mui/icons-material/VpnKeyOutlined";
import MonitorHeartOutlined from "@mui/icons-material/MonitorHeartOutlined";
// import Token from "@mui/icons-material/Token";
import { type FC } from "react";
import { useDashboard } from "components/Dashboard/DashboardProvider";
import { GitIcon } from "components/Icons/GitIcon";
import {
Sidebar as BaseSidebar,
@ -17,8 +16,6 @@ import {
} from "components/Sidebar/Sidebar";
export const Sidebar: FC = () => {
const dashboard = useDashboard();
return (
<BaseSidebar>
<SidebarNavItem href="general" icon={LaunchOutlined}>
@ -52,11 +49,9 @@ export const Sidebar: FC = () => {
<SidebarNavItem href="observability" icon={InsertChartIcon}>
Observability
</SidebarNavItem>
{dashboard.experiments.includes("deployment_health_page") && (
<SidebarNavItem href="/health" icon={MonitorHeartOutlined}>
Health
</SidebarNavItem>
)}
<SidebarNavItem href="/health" icon={MonitorHeartOutlined}>
Health
</SidebarNavItem>
</BaseSidebar>
);
};

View File

@ -2047,9 +2047,7 @@ export const MockEntitlementsWithUserLimit: TypesGen.Entitlements = {
}),
};
export const MockExperiments: TypesGen.Experiment[] = [
"deployment_health_page",
];
export const MockExperiments: TypesGen.Experiment[] = [];
export const MockAuditLog: TypesGen.AuditLog = {
id: "fbd2116a-8961-4954-87ae-e4575bd29ce0",