From 8819f798f8df5203a00b6ba4641b86fcac20d868 Mon Sep 17 00:00:00 2001 From: Colin Adler Date: Thu, 19 Jan 2023 23:31:05 -0600 Subject: [PATCH] fix(helm): revert `app.kubernetes.io/part-of` as a selector (#5806) Deployment selectors are immutable! --- helm/templates/_helpers.tpl | 4 +++- helm/templates/coder.yaml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/helm/templates/_helpers.tpl b/helm/templates/_helpers.tpl index 8b96852f8d..05c02b15de 100644 --- a/helm/templates/_helpers.tpl +++ b/helm/templates/_helpers.tpl @@ -14,11 +14,12 @@ Create chart name and version as used by the chart label. {{/* Selector labels + +!!!!! DO NOT ADD ANY MORE SELECTORS. IT IS A BREAKING CHANGE !!!!! */}} {{- define "coder.selectorLabels" -}} app.kubernetes.io/name: {{ include "coder.name" . }} app.kubernetes.io/instance: {{ .Release.Name }} -app.kubernetes.io/part-of: {{ include "coder.name" . }} {{- end }} {{/* @@ -27,6 +28,7 @@ Common labels {{- define "coder.labels" -}} helm.sh/chart: {{ include "coder.chart" . }} {{ include "coder.selectorLabels" . }} +app.kubernetes.io/part-of: {{ include "coder.name" . }} {{- if .Chart.AppVersion }} app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} {{- end }} diff --git a/helm/templates/coder.yaml b/helm/templates/coder.yaml index fa4d16465e..43e70dd56b 100644 --- a/helm/templates/coder.yaml +++ b/helm/templates/coder.yaml @@ -24,7 +24,7 @@ spec: template: metadata: labels: - {{- include "coder.selectorLabels" . | nindent 8 }} + {{- include "coder.labels" . | nindent 8 }} spec: serviceAccountName: coder restartPolicy: Always