selfhosted
/
coder
mirror of https://github.com/coder/coder.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(coderd): correctly show warning when no provisioner daemons are registered (#11591)

This commit is contained in:
Cian Johnston 2024-01-12 11:22:59 +00:00 committed by GitHub
parent f5a9f5ca3d
commit 0e96115d5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
coderd/healthcheck/provisioner.go
View File

@ -152,7 +152,7 @@ func (r *ProvisionerDaemonsReport) Run(ctx context.Context, opts *ProvisionerDae
if len(r.Items) == 0 {
r.Severity = health.SeverityError
r.Error = ptr.Ref("No active provisioner daemons found!")
r.Warnings = append(r.Warnings, health.Messagef(health.CodeProvisionerDaemonsNoProvisionerDaemons, "No active provisioner daemons found!"))
return
}
}

4
coderd/healthcheck/provisioner_test.go
View File

@ -48,8 +48,8 @@ func TestProvisionerDaemonReport(t *testing.T) {
currentVersion: "v1.2.3",
currentAPIMajorVersion: provisionersdk.CurrentMajor,
expectedSeverity: health.SeverityError,
expectedError: "No active provisioner daemons found!",
expectedItems: []healthcheck.ProvisionerDaemonsReportItem{},
expectedWarningCode: health.CodeProvisionerDaemonsNoProvisionerDaemons,
},
{
name: "error fetching daemons",
@ -303,7 +303,7 @@ func TestProvisionerDaemonReport(t *testing.T) {
currentVersion: "v2.3.4",
currentAPIMajorVersion: provisionersdk.CurrentMajor,
expectedSeverity: health.SeverityError,
expectedError: "No active provisioner daemons found!",
expectedWarningCode: health.CodeProvisionerDaemonsNoProvisionerDaemons,
provisionerDaemons: []database.ProvisionerDaemon{fakeProvisionerDaemonStale(t, "pd-ok", "v1.2.3", "0.9", now.Add(-5*time.Minute), now)},
expectedItems: []healthcheck.ProvisionerDaemonsReportItem{},
},

1
site/src/pages/HealthPage/ProvisionerDaemonsPage.tsx
View File

@ -41,6 +41,7 @@ export const ProvisionerDaemonsPage = () => {
</Header>
<Main>
{daemons.error && <Alert severity="error">{daemons.error}</Alert>}
{daemons.warnings.map((warning) => {
return (
<Alert