selfhosted
/
coder
mirror of https://github.com/coder/coder.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: use error log when failing provisioner job (#6812) 

Co-authored-by: Colin Adler <colin1adler@gmail.com>
This commit is contained in:
ElliotG 2023-04-05 12:30:53 -06:00 committed by GitHub
parent bf1a0791f7
commit 0069831e8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
provisionerd/provisionerd_test.go
View File

@ -1011,7 +1011,7 @@ func TestProvisionerd(t *testing.T) {
t.Cleanup(func() {
close(done)
})
logger := slogtest.Make(t, nil)
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true})
m := sync.Mutex{}
var ops []string
completeChan := make(chan struct{})
@ -1120,7 +1120,7 @@ func createTar(t *testing.T, files map[string]string) []byte {
// Creates a provisionerd implementation with the provided dialer and provisioners.
func createProvisionerd(t *testing.T, dialer provisionerd.Dialer, provisioners provisionerd.Provisioners) *provisionerd.Server {
server := provisionerd.New(dialer, &provisionerd.Options{
Logger: slogtest.Make(t, nil).Named("provisionerd").Leveled(slog.LevelDebug),
Logger: slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Named("provisionerd").Leveled(slog.LevelDebug),
JobPollInterval: 50 * time.Millisecond,
UpdateInterval: 50 * time.Millisecond,
Provisioners: provisioners,

2
provisionerd/runner/runner.go
View File

@ -900,7 +900,7 @@ func (r *Runner) buildWorkspace(ctx context.Context, stage string, req *sdkproto
})
case *sdkproto.Provision_Response_Complete:
if msgType.Complete.Error != "" {
r.logger.Warn(context.Background(), "provision failed; updating state",
r.logger.Error(context.Background(), "provision failed; updating state",
slog.F("state_length", len(msgType.Complete.State)),
slog.F("error", msgType.Complete.Error),
)