2022-10-10 20:37:06 +00:00
|
|
|
package coderd_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/google/uuid"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
|
2023-08-18 18:55:43 +00:00
|
|
|
"github.com/coder/coder/v2/coderd/coderdtest"
|
|
|
|
"github.com/coder/coder/v2/coderd/rbac"
|
|
|
|
"github.com/coder/coder/v2/codersdk"
|
|
|
|
"github.com/coder/coder/v2/enterprise/coderd/coderdenttest"
|
|
|
|
"github.com/coder/coder/v2/enterprise/coderd/license"
|
|
|
|
"github.com/coder/coder/v2/testutil"
|
2022-10-10 20:37:06 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestCheckACLPermissions(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
t.Cleanup(cancel)
|
|
|
|
|
2023-07-12 09:35:29 +00:00
|
|
|
adminClient, adminUser := coderdenttest.New(t, &coderdenttest.Options{
|
2022-10-10 20:37:06 +00:00
|
|
|
Options: &coderdtest.Options{
|
|
|
|
IncludeProvisionerDaemon: true,
|
|
|
|
},
|
2023-07-12 09:35:29 +00:00
|
|
|
LicenseOptions: &coderdenttest.LicenseOptions{
|
|
|
|
Features: license.Features{
|
|
|
|
codersdk.FeatureTemplateRBAC: 1,
|
|
|
|
},
|
2023-01-17 23:04:29 +00:00
|
|
|
},
|
2022-10-10 20:37:06 +00:00
|
|
|
})
|
2023-07-12 09:35:29 +00:00
|
|
|
// Create member and org adminClient
|
2023-02-06 23:48:21 +00:00
|
|
|
memberClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID)
|
2022-10-10 20:37:06 +00:00
|
|
|
memberUser, err := memberClient.User(ctx, codersdk.Me)
|
|
|
|
require.NoError(t, err)
|
2023-02-06 23:48:21 +00:00
|
|
|
orgAdminClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID, rbac.RoleOrgAdmin(adminUser.OrganizationID))
|
2022-10-10 20:37:06 +00:00
|
|
|
orgAdminUser, err := orgAdminClient.User(ctx, codersdk.Me)
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
version := coderdtest.CreateTemplateVersion(t, adminClient, adminUser.OrganizationID, nil)
|
2023-10-03 17:02:56 +00:00
|
|
|
coderdtest.AwaitTemplateVersionJobCompleted(t, adminClient, version.ID)
|
2022-10-10 20:37:06 +00:00
|
|
|
template := coderdtest.CreateTemplate(t, adminClient, adminUser.OrganizationID, version.ID)
|
|
|
|
|
|
|
|
err = adminClient.UpdateTemplateACL(ctx, template.ID, codersdk.UpdateTemplateACL{
|
|
|
|
UserPerms: map[string]codersdk.TemplateRole{
|
|
|
|
memberUser.ID.String(): codersdk.TemplateRoleAdmin,
|
|
|
|
},
|
|
|
|
})
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
const (
|
|
|
|
updateSpecificTemplate = "read-specific-template"
|
|
|
|
)
|
|
|
|
params := map[string]codersdk.AuthorizationCheck{
|
|
|
|
updateSpecificTemplate: {
|
|
|
|
Object: codersdk.AuthorizationObject{
|
2023-04-11 13:57:23 +00:00
|
|
|
ResourceType: codersdk.ResourceTemplate,
|
2022-10-10 20:37:06 +00:00
|
|
|
ResourceID: template.ID.String(),
|
|
|
|
},
|
|
|
|
Action: "write",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
Name string
|
|
|
|
Client *codersdk.Client
|
|
|
|
UserID uuid.UUID
|
|
|
|
Check codersdk.AuthorizationResponse
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
Name: "Admin",
|
|
|
|
Client: adminClient,
|
|
|
|
UserID: adminUser.UserID,
|
|
|
|
Check: map[string]bool{
|
|
|
|
updateSpecificTemplate: true,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "OrgAdmin",
|
|
|
|
Client: orgAdminClient,
|
|
|
|
UserID: orgAdminUser.ID,
|
|
|
|
Check: map[string]bool{
|
|
|
|
updateSpecificTemplate: true,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "Member",
|
|
|
|
Client: memberClient,
|
|
|
|
UserID: memberUser.ID,
|
|
|
|
Check: map[string]bool{
|
|
|
|
updateSpecificTemplate: true,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, c := range testCases {
|
|
|
|
c := c
|
|
|
|
|
|
|
|
t.Run("CheckAuthorization/"+c.Name, func(t *testing.T) {
|
|
|
|
t.Parallel()
|
|
|
|
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
|
|
|
|
t.Cleanup(cancel)
|
|
|
|
|
2023-01-29 21:47:24 +00:00
|
|
|
resp, err := c.Client.AuthCheck(ctx, codersdk.AuthorizationRequest{Checks: params})
|
2022-10-10 20:37:06 +00:00
|
|
|
require.NoError(t, err, "check perms")
|
|
|
|
require.Equal(t, c.Check, resp)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|