Commit Graph

53 Commits

Author SHA1 Message Date
Balasankar 'Balu' C 2ceee4c892 Use gitlab-dangerfiles gem
Use the common features such as changelog checks provided
by gitlab-dangerfiles and clean up the file structure for
easier maintenance and upkeep with the broader changes
across the organization.

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2022-08-16 22:45:11 +00:00
Balasankar 'Balu' C c8995446df Validate installation from PackageCloud
Adds jobs and supporting rake tasks that validate whether a
released package is installable from PackageCloud.

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/3999

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2022-07-27 21:12:24 +00:00
Balasankar 'Balu' C 19aec0fa99 Revert "Merge branch 'use-gitlab-dangerfiles' into 'master'"
This reverts merge request !5947
2022-03-25 03:50:26 +00:00
Rémy Coutable 1b8421cebf
Move Danger rules under danger/
Signed-off-by: Rémy Coutable <remy@rymai.me>
2022-03-24 12:05:17 +01:00
Rémy Coutable 1de98c83e5
Use the \`gitlab-dangerfiles\` gem
Signed-off-by: Rémy Coutable <remy@rymai.me>
2022-03-24 11:12:05 +01:00
Rémy Coutable 73f22b0545 Transition tooling type to maintenance 2022-03-16 11:30:19 +00:00
Rémy Coutable 53bdca2694 Replace "feature::maintenance" with "type::maintenance"
- Brings Omnibus GitLab templates and dependency label
  automation up to date with requirements enacted by
  https://gitlab.com/groups/gitlab-org/-/epics/6622
2022-03-01 19:52:03 +00:00
DJ Mountney 87b84667e6 Merge branch 'gy-dangerbot-spelling-fix' into 'master'
Fix dangerbot spelling mistake

See merge request gitlab-org/omnibus-gitlab!5803
2021-12-21 18:23:29 +00:00
Grant Young 92fe921afa Fix dangerbot spelling mistake 2021-12-21 18:23:29 +00:00
DJ Mountney 89063f62e4 Add ruby upgrade dangerfile 2021-12-20 06:08:10 +00:00
Rémy Coutable 9b34dc403d Transition type labels to the new scoped taxonomy 2021-10-27 08:16:48 +00:00
Robert Marshall 5ea48ada87 Convert software Danger message to checklist
- Convert the message emitted by the software definition Danger job into
  a checklist and update it to match current standards

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>
2021-10-05 02:00:12 -04:00
Robert Marshall def4011d9b Refactor Danger job for software definitions
- Rename array of labels that indicate an engineer tagged a merge
  request as not changing any actual software builds
- Remove labels from label array that are not actually used to indicate
  no changes are happening in a software definition build
- Change name of calculated boolean variable to be clearer on when the
  Danger job should or should not emit a message

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>
2021-10-05 01:05:45 -04:00
Robert Marshall 3d7d9e705f Remove lexographic Danger race condition
- When Danger triggers a job and merges multiple Dangerfiles, it will
  combine all variables together.  This means that the MESSAGE variable
  in the reviewers and software files clobber each other in a race
  condition. Converted these to be unique to ensure message delivery.

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>
2021-10-04 23:15:17 -04:00
Robert Marshall cc546c7df8 Fix broken danger hint for metrics link
- Handbook link for metrics labels changed again breaking the hint
  Danger provides to merge request authors.

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6384

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>
2021-09-02 13:16:24 -04:00
Balasankar "Balu" C 2142acee8d
Make Danger print reviewers message only if no workflow labels exist
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2021-08-06 11:54:15 +05:30
Robert Marshall 69c19633b7 Remove repmgr installation support
- Removes support for installing repmgr and repmgrd
- Leaves repmgr attributes for detection and deprecation
  warning to administrators when running a reconfigure
- Updates rspec tests to reflect removal of repmgr support

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6174

Changelog: removed
2021-06-14 23:51:13 +00:00
Yorick Peterse 3f069305b3
Ensure trailers use the right casing
Changelog trailers are processed case-sensitively by the API. This
updates Danger so it errors when using incorrect casing, such as
`changelog` instead of `Changelog`.

See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/62915 for more
information.
2021-06-01 16:23:09 +02:00
Yorick Peterse 796847ba9a
Tweak Danger to better detect changelog trailers
This makes the regex more strict, and changed the lint_commit method
name to what's being used in gitlab-org/gitlab.

See https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/5173#note_558858405
for more information.
2021-04-23 15:39:39 +02:00
Yorick Peterse bbacc90041
Update Danger for the new changelog setup 2021-04-06 16:41:17 +02:00
Yorick Peterse de96a39bd3
Remove changelog script
This script isn't needed when using the `Changelog` Git trailer.

See https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1551 for
more information.
2021-04-06 13:38:15 +02:00
Robert Marshall 49456aff98 Fix throughput labels broken link and names
- Throughput labels were renamed to engineering metrics in late
  February. Update the Dangerfile to reflect this change and fix the
  broken link inserted to merge requests.

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>
2021-03-12 16:10:47 -05:00
Balasankar "Balu" C a0434ba0ef
Add note about keeping changelog yml file for now
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2021-03-04 14:04:05 +05:30
Yorick Peterse bbb8b62f04
Prepare for the new changelog generation process
This adds the configuration for generating changelogs using the GitLab
API, and extends Danger to suggest using this new setup.

See https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1551 for
more information.
2021-02-16 17:19:40 +01:00
Lin Jen-Shin 011ff2834c
Mention ~"feature::maintenance" over ~backstage 2020-09-22 19:33:05 +08:00
Balasankar "Balu" C a5ed7b5c9e
Support new feature:: and tooling:: labels to replace backstage
Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
2020-07-21 19:08:53 +05:30
Balasankar "Balu" C 24e2b1dbb9
Recommend adding workflow label to notify MR being ready for review
Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
2020-05-22 17:29:24 +05:30
Evan Read 758ff2a36c Merge branch 'docs-is-throughput' into 'master'
Update danger for documentation throughput

See merge request gitlab-org/omnibus-gitlab!4257
2020-05-22 06:15:29 +00:00
Marcel Amirault 7d56675294 Update danger for documentation throughput 2020-05-22 14:09:15 +09:00
Ian Baum fda48876a9
Update Danger reviewer message to reflect changes to assigning 2020-03-27 15:20:11 -05:00
Balasankar "Balu" C a2debd9b33
Revert security harness check to let devs push to dev.gitlab.org
Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
2020-03-17 20:04:34 +05:30
Balasankar "Balu" C 95163aae4b
Fix security harness check
Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
2020-03-17 10:03:54 +05:30
Mayra Cabrera cf9e0392de Updates security-harness for Security remote
Omnibus is currently moving to GitLab Security, so there's no longer a
need to check for dev.gitlab.org repository. This commit updates the
pre-push hook to only check for the Security Remote

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/692
2020-03-13 08:35:54 -06:00
Balasankar "Balu" C e8413f9969
Make danger not complain on other group:: labels
Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
2020-03-12 21:52:18 +05:30
Mayra Cabrera 8e27545869 Update security-harness for Security remote
Updates the pre-push hook to check for dev.gitlab.org or
gitlab-org/security remote. Script was added to rubocop exclusion list

Backporting from 7a4d9abfdd

Related to https://gitlab.com/groups/gitlab-com/gl-infra/-/epics/121
2019-12-16 10:43:06 -06:00
Evan Read c1c97fb612 Fix case for documentation label, and some docs links 2019-09-30 17:08:52 +00:00
Ian Baum aa49907c3f Add scripts/repack-deb
repacks an existing deb with relevant content from the local branch
Useful for testing changes to package trigger scripts
2019-09-27 04:49:12 +00:00
Balasankar "Balu" C 7eb68bea71
Fix Balu's official gitlab handle
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2019-09-13 16:22:51 +05:30
Ian Baum 2e7665254d Reformat output to be one entry
Danger treats each message call as a separate entry
2019-09-06 17:58:39 +00:00
Steven Wilson 3c8c134f0c Danger warn on missing group::distribution label instead of Distribution 2019-08-01 00:07:04 +00:00
Ian Baum 11c4590546 Upgrade rubocop to 0.73.0
* Add rubocop-rails and rubocop-performance gems
* Update renamed gems in .rubocop.yml
* Auto-correct where possible
* Manually fix remaining gems
2019-07-31 20:07:32 +00:00
DJ Mountney 8bc14ede07
Add a warning regarding throughput labels to danger
If your MR is missing throughput labels, throw a warning.
2019-07-11 16:21:38 -07:00
Balasankar "Balu" C 224307cb8f
Warn if Distribution label is missing
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2019-04-18 19:35:50 +05:30
Alessio Caiazza 6b977ded4b Dangerfile: check if gitlab.rb.template is changed
Don't warn about user facing config changes when
files/gitlab-config-template/gitlab.rb.template is modified
2019-04-02 11:40:48 +02:00
Felipe Artur a99a58ddb1 Fix security harness script
"[[" Syntax is not supported on debian based systems.
2019-02-13 11:40:08 -02:00
Ian Baum 2edb00e33b Add scripts/changelog 2019-02-07 21:04:41 +00:00
Balasankar "Balu" C 806c2708d2
Warn reviewers to rebuild packages if software definition changed, not fail 2019-01-30 16:56:37 +05:30
Marin Jankovski ec02a9365f
Add danger gem checks to new MRs.
Any change to user configuration should contain an update to gitlab.rb.template.
All MR's have to have correct metadata applied such as milestones and labels.
Most cookbook changes will require specs.
Changes to bundled libraries most of the time requre a build on all platforms
and a manual package test.
2018-07-25 17:04:38 +02:00
Fabien Catteau bf830debf2
Download gitlab-depscan from security-products project 2018-06-05 19:19:55 +02:00
Robert Speicher 574478f2c6 Add security-harness script
See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17097
2018-04-10 10:21:35 -05:00