Commit Graph

31 Commits

Author SHA1 Message Date
Balasankar 'Balu' C 22ae898b24 Add Rubocop cop to enforce default_version in software definitions
Prevent empty build caches caused by a lack of default version.

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8476

Signed-off-by: Balasankar 'Balu' C <balasankar@gitlab.com>
2024-04-08 16:29:41 +00:00
Balasankar "Balu" C 6936df9e78
Cleanup requires across library files
* Ensure every library `require`s all the other libraries it needs for
  functioning.
* Ensure require statements come before require_relative ones
* Ensure require_relative statements doesn't end with `.rb` extension
    * Also enabled the Cop for that
* Use single quotes for require statements

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2024-01-30 10:41:53 +05:30
Takuya Noguchi db7ad34d52 Enable Style/GlobalVars cop through all files in RuboCop
lib/backup diretory does not exist any more and no offense is found
under lib/tasks.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Changelog: other
2022-09-21 08:31:58 +00:00
Takuya Noguchi ee1c189130 Update gitlab-styles from 7.1.0 to 9.0.0
to update rubocop from 0.93.1 to 1.36.0.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Changelog: fixed
2022-09-15 15:06:20 +00:00
Balasankar 'Balu' C 2ceee4c892 Use gitlab-dangerfiles gem
Use the common features such as changelog checks provided
by gitlab-dangerfiles and clean up the file structure for
easier maintenance and upkeep with the broader changes
across the organization.

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2022-08-16 22:45:11 +00:00
Balasankar 'Balu' C 19aec0fa99 Revert "Merge branch 'use-gitlab-dangerfiles' into 'master'"
This reverts merge request !5947
2022-03-25 03:50:26 +00:00
Rémy Coutable 1b8421cebf
Move Danger rules under danger/
Signed-off-by: Rémy Coutable <remy@rymai.me>
2022-03-24 12:05:17 +01:00
Balasankar 'Balu' C 4a31b9d797 Move specs testing non-chef components to own directory
- Moves Build and Tasks rspecs into the lib directory

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/3217

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
2022-03-18 02:46:44 +00:00
Takuya Noguchi 44ce9f2e10 Update gitlab-styles from 4.3.0 to 6.1.0
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2021-04-26 22:26:00 +00:00
Stan Hu d09a84eefb Bump gitlab-styles version to pull in Rubocop update 2020-10-30 21:55:20 -07:00
Gabriel Mazetto 878f046847 Disable Style/MultilineIfModifier cop as its useful for our case
We are in-fact having to disable it everywhere because we actually need
that pattern, so there is no point in not disabling it from rubocop
anyway.
2020-07-28 13:43:07 +01:00
Mayra Cabrera 8e27545869 Update security-harness for Security remote
Updates the pre-push hook to check for dev.gitlab.org or
gitlab-org/security remote. Script was added to rubocop exclusion list

Backporting from 7a4d9abfdd

Related to https://gitlab.com/groups/gitlab-com/gl-infra/-/epics/121
2019-12-16 10:43:06 -06:00
DJ Mountney 4a0c4f7524
Drop the env util changes 2019-07-31 17:03:14 -07:00
DJ Mountney 2893526458
Update the todo list with the current gitlab-styles changes 2019-07-31 14:27:15 -07:00
DJ Mountney 9191f15bb8
Switch to using gitlab-styles for rubocop 2019-07-31 14:18:19 -07:00
Ian Baum 11c4590546 Upgrade rubocop to 0.73.0
* Add rubocop-rails and rubocop-performance gems
* Update renamed gems in .rubocop.yml
* Auto-correct where possible
* Manually fix remaining gems
2019-07-31 20:07:32 +00:00
Ian Baum 2edb00e33b Add scripts/changelog 2019-02-07 21:04:41 +00:00
Balasankar "Balu" C 7ecadb7083
Add tests for Gitlab::Util module 2019-01-31 10:27:41 +05:30
Balasankar "Balu" C 4264692b38
Add Rubocop cop for preventing ENV usage 2019-01-29 16:50:29 +05:30
Balasankar "Balu" C 189cbe419f
Ignore runit code from rubocop 2019-01-17 10:56:55 +05:30
Takuya Noguchi 1b412e31d0 Completely update Ruby to 2.4.4 2018-06-28 10:02:54 +09:00
Takuya Noguchi cee59f19ea Update rubocop to 0.52.1 2018-02-28 23:29:02 +09:00
Balasankar "Balu" C 6f266c621b Reduce permitted AbcSize limit 2018-01-30 01:32:57 +05:30
Balasankar "Balu" C c21d957e20 Properly ignore gems directory from rubocop list 2018-01-30 01:26:11 +05:30
Balasankar "Balu" C 639efc3e4d Exclude external directories 2018-01-30 01:26:11 +05:30
Balasankar "Balu" C f416cc3549 Make everything rubocop friendly 2018-01-30 01:26:11 +05:30
Zeger-Jan van de Weg e696babb00 Allow object store settings to be set for artifacts 2017-06-19 19:10:57 +00:00
Balasankar C 83bb626ce8 Run rubocop over specs 2017-04-03 15:45:07 +00:00
Balasankar C 9873bf0c85 Run rubocop over lib directory 2017-03-16 10:37:05 +00:00
Balasankar C e42c7723f7 Fix image 2017-02-23 15:52:42 +00:00
Balasankar C 90de700482 Run rubocop over software definitions 2017-02-13 17:22:39 +05:30