diff --git a/Dangerfile b/Dangerfile index 19c577748..6bb151dea 100644 --- a/Dangerfile +++ b/Dangerfile @@ -2,8 +2,9 @@ require 'gitlab-dangerfiles' -Gitlab::Dangerfiles.for_project(self) do |gitlab_dangerfiles| +# Documentation reference: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles +Gitlab::Dangerfiles.for_project(self, 'omnibus-gitlab') do |gitlab_dangerfiles| gitlab_dangerfiles.import_plugins - gitlab_dangerfiles.import_dangerfiles(except: %w[simple_roulette]) + gitlab_dangerfiles.import_dangerfiles end diff --git a/danger/reviewers/Dangerfile b/danger/reviewers/Dangerfile index ed892c494..21b007b00 100644 --- a/danger/reviewers/Dangerfile +++ b/danger/reviewers/Dangerfile @@ -3,11 +3,11 @@ return if helper.has_scoped_label_with_scope?("workflow") REVIEWERS_MESSAGE = <<~MSG -Please add the ~"workflow::ready for review" label once you think the MR is ready to for an initial review. +Once your MR is ready for review you can comment `@gitlab-bot ready <@user>` to request the first review to someone. It's recommended that you pick the one suggested by the reviewer roulette. But you can ignore it and assign it to someone else if you see fit. -Merge requests are handled according to the workflow documented in our [handbook](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html) and should receive a response within the limit documented in our [First-response SLO](https://about.gitlab.com/handbook/engineering/workflow/code-review/#first-response-slo). +Merge requests are handled according to the workflow documented in our [handbook](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html#workflow) and should receive a response within the limit documented in our [Service-level objective (SLO)](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html#service-level-objective). -If you don't receive a response, please mention `@gitlab-org\/distribution`, or one of our [Project Maintainers](https://about.gitlab.com/handbook/engineering/projects/#omnibus-gitlab) +If you don't receive a response from the reviewer within the SLO, please mention `@gitlab-org\/distribution`, or one of our [Project Maintainers](https://about.gitlab.com/handbook/engineering/projects/#omnibus-gitlab) MSG # Print maintainers message