gitlab
/
cli
mirror of https://gitlab.com/gitlab-org/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Handle trailing slash in remote URL

This commit is contained in:
Eli Treuherz 2023-08-01 03:00:08 +00:00 committed by Jay McCure
parent 26c48951f9
commit 43f6e60bd3
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/glrepo/repo.go
View File

@ -45,6 +45,7 @@ func FullNameFromURL(remoteURL string) (string, error) {
return "", errors.New("cannot parse remote: " + remoteURL)
}
repo := parts[1]
repo = strings.TrimSuffix(repo, "/")
repo = strings.TrimSuffix(repo, ".git")
return repo, nil
}

15
internal/glrepo/repo_test.go
View File

@ -364,6 +364,21 @@ func TestFullNameFromURL(t *testing.T) {
want: "profclems/glab",
wantErr: nil,
},
{
remoteURL: "https://gitlab.com/profclems/glab",
want: "profclems/glab",
wantErr: nil,
},
{
remoteURL: "https://gitlab.com/profclems/glab/",
want: "profclems/glab",
wantErr: nil,
},
{
remoteURL: "https://gitlab.com/profclems/glab.git/",
want: "profclems/glab",
wantErr: nil,
},
{
remoteURL: "https://gitlab.com/owner/namespace/repo.git",
want: "owner/namespace/repo",