Update ghcr.io/visualon/renovate Docker tag to v37.330.1

Merge pull request 'Fix SQL command with too many placeholders' (#3570 ) from algernon/forgejo:many-question-marks-handle-it into forgejo
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3570 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 06:02:32 +00:00 · 2024-05-01 05:24:08 +00:00 · 2024-05-01 00:34:48 +02:00 · 2024-05-01 00:34:39 +02:00
5 changed files with 17 additions and 1 deletions
--- a/.forgejo/workflows/renovate.yml
+++ b/.forgejo/workflows/renovate.yml
@ -22,7 +22,7 @@ jobs:

    runs-on: docker
    container:
-      image: ghcr.io/visualon/renovate:37.323.3
+      image: ghcr.io/visualon/renovate:37.330.1

    steps:
      - name: Load renovate repo cache
--- a/models/git/branch_list.go
+++ b/models/git/branch_list.go
@ -116,6 +116,9 @@ func FindBranchNames(ctx context.Context, opts FindBranchOptions) ([]string, err
 }

 func FindBranchesByRepoAndBranchName(ctx context.Context, repoBranches map[int64]string) (map[int64]string, error) {
+	if len(repoBranches) == 0 {
+		return nil, nil
+	}
 	cond := builder.NewCond()
 	for repoID, branchName := range repoBranches {
 		cond = cond.Or(builder.And(builder.Eq{"repo_id": repoID}, builder.Eq{"name": branchName}))
--- a/models/git/branch_test.go
+++ b/models/git/branch_test.go
@ -183,3 +183,12 @@ func TestOnlyGetDeletedBranchOnCorrectRepo(t *testing.T) {
 	assert.NoError(t, err)
 	assert.NotNil(t, deletedBranch)
 }
+
+func TestFindBranchesByRepoAndBranchName(t *testing.T) {
+	assert.NoError(t, unittest.PrepareTestDatabase())
+
+	// With no repos or branches given, we find no branches.
+	branches, err := git_model.FindBranchesByRepoAndBranchName(db.DefaultContext, map[int64]string{})
+	assert.NoError(t, err)
+	assert.Len(t, branches, 0)
+}
--- a/release-notes/8.0.0/fix/3570.md
+++ b/release-notes/8.0.0/fix/3570.md
@ -0,0 +1 @@
+Fixed an issue that resulted in excessive and unnecessary database queries when a user with no repositories was viewing their dashboard.
--- a/services/repository/commitstatus/commitstatus.go
+++ b/services/repository/commitstatus/commitstatus.go
@ -127,6 +127,9 @@ func CreateCommitStatus(ctx context.Context, repo *repo_model.Repository, creato

 // FindReposLastestCommitStatuses loading repository default branch latest combinded commit status with cache
 func FindReposLastestCommitStatuses(ctx context.Context, repos []*repo_model.Repository) ([]*git_model.CommitStatus, error) {
+	if len(repos) == 0 {
+		return nil, nil
+	}
 	results := make([]*git_model.CommitStatus, len(repos))
 	for i, repo := range repos {
 		if cv := getCommitStatusCache(repo.ID, repo.DefaultBranch); cv != nil {
Author	SHA1	Message	Date
Renovate Bot	15978d4d07	Update ghcr.io/visualon/renovate Docker tag to v37.330.1	2024-05-01 06:02:32 +00:00
Earl Warren	288747c660	Merge pull request 'Fix SQL command with too many placeholders' (#3570 ) from algernon/forgejo:many-question-marks-handle-it into forgejo Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3570 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>	2024-05-01 05:24:08 +00:00
Gergely Nagy	33cd8446d3	Performance improvement for FindReposLastestCommitStatuses If `commitstatus_service.FindReposLastestCommitStatuses` receives no repos in its params, short-circuit, and return early, without performing any potentially expensive work. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>	2024-05-01 00:34:48 +02:00
Gergely Nagy	0d029ebe6d	Fix git_model.FindBranchesByRepoAndBranchName When a logged in user with no repositories visits their dashboard, it will display a search box that lists their own repositories. This is served by the `repo.SearchRepos` handler, which in turn calls `commitstatus_service.FindReposLastestCommitStatuses()` with an empty repo list. That, in turn, will call `git_model.FindBranchesByRepoAndBranchName()`, with an empty map. With no map, `FindBranchesByRepoAndBranchName()` ends up querying the entire `branch` table, because no conditions were set up. Armed with a gazillion repo & commit shas, we return to `FindReposLastestCommitStatuses`, and promptly call `git_model.GetLatestCommitStatusForPairs`, which constructs a monstrous query with so many placeholders that the database tells us to go somewhere else, and flips us off. At least on instances the size of Codeberg. On smaller instances, it will eventually return, and throw away all the data, and return an empty set, having performed all this for naught. We fix this by short-circuiting `FindBranchesByRepoAndBranchName`, and returning fast if our inputs are empty. A test case is included. Fixes #3521. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>	2024-05-01 00:34:39 +02:00
				`@ -0,0 +1 @@`
				`Fixed an issue that resulted in excessive and unnecessary database queries when a user with no repositories was viewing their dashboard.`