From 574c7f218ebaa6593e8f644d4f981b2dd60c210f Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Sun, 21 Apr 2024 15:12:27 +0200
Subject: [PATCH] fix(labels): allow link shares to add existing labels to a
 task

Resolves https://github.com/go-vikunja/vikunja/issues/252
---
 .../src/components/home/contentLinkShare.vue  |  4 ++
 frontend/src/stores/labels.ts                 |  1 -
 frontend/src/views/tasks/TaskDetailView.vue   |  4 +-
 pkg/models/label.go                           | 13 +-----
 pkg/models/label_rights.go                    | 19 +++++----
 pkg/models/label_task.go                      | 42 +++++++++++--------
 pkg/routes/caldav/listStorageProvider.go      |  2 +-
 7 files changed, 45 insertions(+), 40 deletions(-)

diff --git a/frontend/src/components/home/contentLinkShare.vue b/frontend/src/components/home/contentLinkShare.vue
index 95cf3dc15..cc14d318f 100644
--- a/frontend/src/components/home/contentLinkShare.vue
+++ b/frontend/src/components/home/contentLinkShare.vue
@@ -34,6 +34,7 @@ import {useBaseStore} from '@/stores/base'
 import Logo from '@/components/home/Logo.vue'
 import PoweredByLink from './PoweredByLink.vue'
 import {useProjectStore} from '@/stores/projects'
+import {useLabelStore} from '@/stores/labels'
 
 const baseStore = useBaseStore()
 const currentProject = computed(() => baseStore.currentProject)
@@ -42,6 +43,9 @@ const logoVisible = computed(() => baseStore.logoVisible)
 
 const projectStore = useProjectStore()
 projectStore.loadAllProjects()
+
+const labelStore = useLabelStore()
+labelStore.loadAllLabels()
 </script>
 
 <style lang="scss" scoped>
diff --git a/frontend/src/stores/labels.ts b/frontend/src/stores/labels.ts
index 9c3d959b0..3c470be4e 100644
--- a/frontend/src/stores/labels.ts
+++ b/frontend/src/stores/labels.ts
@@ -160,7 +160,6 @@ export const useLabelStore = defineStore('label', () => {
 		deleteLabel,
 		updateLabel,
 		createLabel,
-		
 	}
 })
 
diff --git a/frontend/src/views/tasks/TaskDetailView.vue b/frontend/src/views/tasks/TaskDetailView.vue
index 8a2b4c6f7..71ab1f95b 100644
--- a/frontend/src/views/tasks/TaskDetailView.vue
+++ b/frontend/src/views/tasks/TaskDetailView.vue
@@ -309,6 +309,7 @@
 							v-model="task.labels"
 							:disabled="!canWrite"
 							:task-id="taskId"
+							:creatable="!authStore.isLinkShareAuth"
 						/>
 					</div>
 
@@ -653,6 +654,7 @@ const projectStore = useProjectStore()
 const attachmentStore = useAttachmentStore()
 const taskStore = useTaskStore()
 const kanbanStore = useKanbanStore()
+const authStore = useAuthStore()
 
 const task = ref<ITask>(new TaskModel())
 const taskTitle = computed(() => task.value.title)
@@ -877,7 +879,7 @@ function toggleTaskDone() {
 		done: !task.value.done,
 	}
 
-	if (newTask.done && useAuthStore().settings.frontendSettings.playSoundWhenDone) {
+	if (newTask.done && authStore.settings.frontendSettings.playSoundWhenDone) {
 		playPopSound()
 	}
 
diff --git a/pkg/models/label.go b/pkg/models/label.go
index ef234b79f..b6e473385 100644
--- a/pkg/models/label.go
+++ b/pkg/models/label.go
@@ -148,23 +148,14 @@ func (l *Label) Delete(s *xorm.Session, _ web.Auth) (err error) {
 // @Failure 500 {object} models.Message "Internal error"
 // @Router /labels [get]
 func (l *Label) ReadAll(s *xorm.Session, a web.Auth, search string, page int, perPage int) (ls interface{}, resultCount int, numberOfEntries int64, err error) {
-	if _, is := a.(*LinkSharing); is {
-		return nil, 0, 0, ErrGenericForbidden{}
-	}
-
-	u, err := user.GetUserByID(s, a.GetID())
-	if err != nil {
-		return nil, 0, 0, err
-	}
-
 	return GetLabelsByTaskIDs(s, &LabelByTaskIDsOptions{
 		Search:              []string{search},
-		User:                u,
-		GetForUser:          u.ID,
+		User:                a,
 		Page:                page,
 		PerPage:             perPage,
 		GetUnusedLabels:     true,
 		GroupByLabelIDsOnly: true,
+		GetForUser:          true,
 	})
 }
 
diff --git a/pkg/models/label_rights.go b/pkg/models/label_rights.go
index 8cd0a48c3..941a7099f 100644
--- a/pkg/models/label_rights.go
+++ b/pkg/models/label_rights.go
@@ -17,7 +17,6 @@
 package models
 
 import (
-	"code.vikunja.io/api/pkg/user"
 	"code.vikunja.io/web"
 	"xorm.io/builder"
 	"xorm.io/xorm"
@@ -64,27 +63,29 @@ func (l *Label) isLabelOwner(s *xorm.Session, a web.Auth) (bool, error) {
 // Helper method to check if a user can see a specific label
 func (l *Label) hasAccessToLabel(s *xorm.Session, a web.Auth) (has bool, maxRight int, err error) {
 
-	if _, is := a.(*LinkSharing); is {
-		return false, 0, nil
-	}
+	linkShare, isLinkShare := a.(*LinkSharing)
 
-	u, err := user.GetUserByID(s, a.GetID())
-	if err != nil {
-		return false, 0, err
+	var where builder.Cond
+	var createdByID int64
+	if isLinkShare {
+		where = builder.Eq{"project_id": linkShare.ProjectID}
+	} else {
+		where = builder.In("project_id", getUserProjectsStatement(a.GetID(), "", false).Select("l.id"))
+		createdByID = a.GetID()
 	}
 
 	cond := builder.In("label_tasks.task_id",
 		builder.
 			Select("id").
 			From("tasks").
-			Where(builder.In("project_id", getUserProjectsStatement(u.ID, "", false).Select("l.id"))),
+			Where(where),
 	)
 
 	ll := &LabelTask{}
 	has, err = s.Table("labels").
 		Select("label_tasks.*").
 		Join("LEFT", "label_tasks", "label_tasks.label_id = labels.id").
-		Where("label_tasks.label_id is not null OR labels.created_by_id = ?", u.ID).
+		Where("label_tasks.label_id is not null OR labels.created_by_id = ?", createdByID).
 		Or(cond).
 		And("labels.id = ?", l.ID).
 		Exist(ll)
diff --git a/pkg/models/label_task.go b/pkg/models/label_task.go
index 4e68c446b..3ff141f87 100644
--- a/pkg/models/label_task.go
+++ b/pkg/models/label_task.go
@@ -144,7 +144,7 @@ func (lt *LabelTask) ReadAll(s *xorm.Session, a web.Auth, search string, page in
 	}
 
 	return GetLabelsByTaskIDs(s, &LabelByTaskIDsOptions{
-		User:    &user.User{ID: a.GetID()},
+		User:    a,
 		Search:  []string{search},
 		Page:    page,
 		TaskIDs: []int64{lt.TaskID},
@@ -159,23 +159,26 @@ type LabelWithTaskID struct {
 
 // LabelByTaskIDsOptions is a struct to not clutter the function with too many optional parameters.
 type LabelByTaskIDsOptions struct {
-	User                *user.User
+	User                web.Auth
 	Search              []string
 	Page                int
 	PerPage             int
 	TaskIDs             []int64
 	GetUnusedLabels     bool
 	GroupByLabelIDsOnly bool
-	GetForUser          int64
+	GetForUser          bool
 }
 
 // GetLabelsByTaskIDs is a helper function to get all labels for a set of tasks
 // Used when getting all labels for one task as well when getting all lables
 func GetLabelsByTaskIDs(s *xorm.Session, opts *LabelByTaskIDsOptions) (ls []*LabelWithTaskID, resultCount int, totalEntries int64, err error) {
+
+	linkShare, isLinkShareAuth := opts.User.(*LinkSharing)
+
 	// We still need the task ID when we want to get all labels for a task, but because of this, we get the same label
 	// multiple times when it is associated to more than one task.
 	// Because of this whole thing, we need this extra switch here to only group by Task IDs if needed.
-	// Probably not the most ideal solution.
+	// Probably not the most ideataskdetaill solution.
 	var groupBy = "labels.id,label_tasks.task_id"
 	var selectStmt = "labels.*, label_tasks.task_id"
 	if opts.GroupByLabelIDsOnly {
@@ -186,20 +189,25 @@ func GetLabelsByTaskIDs(s *xorm.Session, opts *LabelByTaskIDsOptions) (ls []*Lab
 	// Get all labels associated with these tasks
 	var labels []*LabelWithTaskID
 	cond := builder.And(builder.NotNull{"label_tasks.label_id"})
-	if len(opts.TaskIDs) > 0 && opts.GetForUser == 0 {
+	if len(opts.TaskIDs) > 0 && !opts.GetForUser {
 		cond = builder.And(builder.In("label_tasks.task_id", opts.TaskIDs), cond)
 	}
-	if opts.GetForUser != 0 {
+	if opts.GetForUser {
 
-		projects, _, _, err := getRawProjectsForUser(s, &projectOptions{
-			user: &user.User{ID: opts.GetForUser},
-		})
-		if err != nil {
-			return nil, 0, 0, err
-		}
-		projectIDs := make([]int64, 0, len(projects))
-		for _, project := range projects {
-			projectIDs = append(projectIDs, project.ID)
+		var projectIDs []int64
+		if isLinkShareAuth {
+			projectIDs = []int64{linkShare.ProjectID}
+		} else {
+			projects, _, _, err := getRawProjectsForUser(s, &projectOptions{
+				user: &user.User{ID: opts.User.GetID()},
+			})
+			if err != nil {
+				return nil, 0, 0, err
+			}
+			projectIDs = make([]int64, 0, len(projects))
+			for _, project := range projects {
+				projectIDs = append(projectIDs, project.ID)
+			}
 		}
 
 		cond = builder.And(builder.In("label_tasks.task_id",
@@ -209,8 +217,8 @@ func GetLabelsByTaskIDs(s *xorm.Session, opts *LabelByTaskIDsOptions) (ls []*Lab
 				Where(builder.In("project_id", projectIDs)),
 		), cond)
 	}
-	if opts.GetUnusedLabels {
-		cond = builder.Or(cond, builder.Eq{"labels.created_by_id": opts.User.ID})
+	if opts.GetUnusedLabels && !isLinkShareAuth {
+		cond = builder.Or(cond, builder.Eq{"labels.created_by_id": opts.User.GetID()})
 	}
 
 	ids := []int64{}
diff --git a/pkg/routes/caldav/listStorageProvider.go b/pkg/routes/caldav/listStorageProvider.go
index f513912e8..7c829c329 100644
--- a/pkg/routes/caldav/listStorageProvider.go
+++ b/pkg/routes/caldav/listStorageProvider.go
@@ -419,7 +419,7 @@ func persistLabels(s *xorm.Session, a web.Auth, task *models.Task, labels []*mod
 	existingLabels, _, _, err := models.GetLabelsByTaskIDs(s, &models.LabelByTaskIDsOptions{
 		Search:              labelTitles,
 		User:                u,
-		GetForUser:          u.ID,
+		GetForUser:          true,
 		GetUnusedLabels:     true,
 		GroupByLabelIDsOnly: true,
 	})